Skip to content

Commit c90f2ac

Browse files
shaun-nxCopilot
andauthored
Apply suggestions from code review
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent e202905 commit c90f2ac

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

docs/proposals/authentication-filter.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -478,7 +478,7 @@ http {
478478
For JWT Auth, there are two options.
479479

480480
1. Local JWKS file stored as a Secret
481-
2. Remote JWKS from an IdP provider like KeyCloak
481+
2. Remote JWKS from an IdP provider like Keycloak
482482

483483
#### Example JWT AuthenticationFilter with Local JWKS
484484

@@ -919,7 +919,7 @@ This scenario can use the status `RouteConditionPartiallyInvalid` defined in the
919919

920920
The Gateway API defines a means to standardise authentication through use of the [HTTPExternalAuthFilter](https://gateway-api.sigs.k8s.io/reference/spec/#httpexternalauthfilter) available in the HTTPRoute specification.
921921

922-
This allows users to reference an external authentication service, such as KeyCloak, to handle the authentication requests.
922+
This allows users to reference an external authentication service, such as Keycloak, to handle the authentication requests.
923923
While this API is available in the experimental channel, it is subject to change.
924924

925925
Our decision to go forward with our own `AuthenticationFilter` was to ensure we could quickly provide authentication to our users while allowing us to closely monitor progress of the ExternalAuthFilter.
@@ -1030,7 +1030,7 @@ spec:
10301030
name: basic-auth-users
10311031
```
10321032
1033-
AuthenticationFilter referencing the cross-namespace Secret
1033+
10341034
10351035
```yaml
10361036
apiVersion: gateway.nginx.org/v1alpha1

0 commit comments

Comments
 (0)