Address feedback

Author: bjee19

internal/controller/nginx/config/servers.go

@@ -634,7 +634,7 @@ func createInternalLocationsForRule(
 				}
 			}
 
-			// skip adding match and creating split clients location if its a duplicate intEPPLocation.Path
+			// skip adding match and creating split clients location if it's a duplicate intEPPLocation.Path
 			if skipMatch {
 				continue
 			}
@@ -973,19 +973,33 @@ func initializeInternalInferenceEPPLocation(
 ) http.Location {
 	return http.Location{
 		// This path needs to be recreated in the split_clients directive generation to match correctly.
-		Path: fmt.Sprintf(
-			"%s-%s-%s-%s-routeRule%d-pathRule%d",
-			http.InternalRoutePathPrefix,
+		Path: generateInternalInferenceEPPLocationPath(
 			b.UpstreamName,
-			source.Namespace,
-			source.Name,
+			source,
 			ruleIdx,
 			pathruleIdx,
 		),
 		Type: http.InferenceInternalLocationType,
 	}
 }
 
+func generateInternalInferenceEPPLocationPath(
+	upstreamName string,
+	source types.NamespacedName,
+	ruleIdx int,
+	pathRuleIdx int,
+) string {
+	return fmt.Sprintf(
+		"%s-%s-%s-%s-routeRule%d-pathRule%d",
+		http.InternalRoutePathPrefix,
+		upstreamName,
+		source.Namespace,
+		source.Name,
+		ruleIdx,
+		pathRuleIdx,
+	)
+}
+
 // initializeInternalInferenceProxyPassLocation initializes the internal inference location that does the final
 // proxy_pass to the inference backend.
 func initializeInternalInferenceProxyPassLocation(pathruleIdx, matchRuleIdx, backendIdx int) http.Location {

internal/controller/nginx/config/split_clients.go

@@ -187,12 +187,9 @@ func createBackendGroupSplitClientDistributions(group dataplane.BackendGroup) []
 func getSplitClientValue(b dataplane.Backend, source types.NamespacedName, ruleIdx, pathRuleIdx int) string {
 	if b.Valid {
 		if b.EndpointPickerConfig != nil {
-			return fmt.Sprintf(
-				"%s-%s-%s-%s-routeRule%d-pathRule%d",
-				http.InternalRoutePathPrefix,
+			return generateInternalInferenceEPPLocationPath(
 				b.UpstreamName,
-				source.Namespace,
-				source.Name,
+				source,
 				ruleIdx,
 				pathRuleIdx,
 			)

internal/controller/state/dataplane/types.go

@@ -311,7 +311,8 @@ type BackendGroup struct {
 	Backends []Backend
 	// RuleIdx is the index of the corresponding rule in the HTTPRoute.
 	RuleIdx int
-	// PathRuleIdx is the index of the corresponding path rule in the HTTPRoute.
+	// PathRuleIdx is the index of the corresponding path rule when attached to a VirtualServer.
+	// BackendGroups attached to a MatchRule that have the same Path match will have the same PathRuleIdx.
 	PathRuleIdx int
 }