-
Notifications
You must be signed in to change notification settings - Fork 150
Add functional tests for Session Persistence OSS and Plus #4406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
salonichf5
merged 3 commits into
feat/session-persistence
from
tests/session-persistence
Dec 9, 2025
Merged
Add functional tests for Session Persistence OSS and Plus #4406
salonichf5
merged 3 commits into
feat/session-persistence
from
tests/session-persistence
Dec 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96944ec to
d83f893
Compare
Contributor
|
oh, thank you! this PR helps me a lot with ProxySettings functional tests! |
7e943f4 to
4f7306a
Compare
4f7306a to
53bff8a
Compare
sjberman
reviewed
Dec 8, 2025
sjberman
approved these changes
Dec 8, 2025
tataruty
approved these changes
Dec 9, 2025
Contributor
tataruty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: We want to ensure everything works as expected for Session persistence feature
Solution: Add functional tests for Session persistence
Did some code refactoring for request and response, verified all tests pass
Testing: Ran tests locally
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #4232
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.