Skip to content

Conversation

@salonichf5
Copy link
Contributor

@salonichf5 salonichf5 commented Dec 5, 2025

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: We want to ensure everything works as expected for Session persistence feature

Solution: Add functional tests for Session persistence

Did some code refactoring for request and response, verified all tests pass

Testing: Ran tests locally

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #4232

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@github-actions github-actions bot added the tests Pull requests that update tests label Dec 5, 2025
@salonichf5 salonichf5 force-pushed the tests/session-persistence branch from 96944ec to d83f893 Compare December 5, 2025 22:03
@tataruty
Copy link
Contributor

tataruty commented Dec 8, 2025

oh, thank you! this PR helps me a lot with ProxySettings functional tests!

@salonichf5 salonichf5 force-pushed the tests/session-persistence branch from 7e943f4 to 4f7306a Compare December 8, 2025 18:06
@salonichf5 salonichf5 force-pushed the tests/session-persistence branch from 4f7306a to 53bff8a Compare December 8, 2025 18:44
@salonichf5 salonichf5 changed the title DNR: Add functional tests for Session Persistence OSS and Plus Add functional tests for Session Persistence OSS and Plus Dec 8, 2025
@salonichf5 salonichf5 marked this pull request as ready for review December 8, 2025 19:25
@salonichf5 salonichf5 requested a review from a team as a code owner December 8, 2025 19:25
Copy link
Contributor

@tataruty tataruty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@salonichf5 salonichf5 merged commit b424d7d into feat/session-persistence Dec 9, 2025
54 of 56 checks passed
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Dec 9, 2025
@salonichf5 salonichf5 deleted the tests/session-persistence branch December 9, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Pull requests that update tests

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants