NH-1904 - public properties cannot have the same name with different case, test case and fix for struct components

Author: fredericDelaporte

src/NHibernate.Test/NHSpecificTest/NH1904/Model.cs

@@ -9,4 +9,19 @@ public class Invoice
 
 		protected virtual DateTime issued { get; set; }
 	}
+
+	public class InvoiceWithAddress : Invoice
+	{
+		public virtual Address BillingAddress { get; set; }
+	}
+
+	public struct Address
+	{
+		public string Line { get; set; }
+		public string line { get; set; }
+		public string Line2 { get; set; }
+		public string City { get; set; }
+		public string ZipCode { get; set; }
+		public string Country { get; set; }
+	}
 }

src/NHibernate.Test/NHSpecificTest/NH1904/StructFixture.cs

@@ -0,0 +1,47 @@
+using System;
+using System.Collections;
+using NUnit.Framework;
+
+namespace NHibernate.Test.NHSpecificTest.NH1904
+{
+	[TestFixture]
+	public class StructFixture : BugTestCase
+	{
+		protected override IList Mappings =>
+			new string[]
+			{
+				"NHSpecificTest." + BugNumber + ".StructMappings.hbm.xml"
+			};
+
+		[Test]
+		public void ExecuteQuery()
+		{
+			using (ISession session = OpenSession())
+			using (ITransaction transaction = session.BeginTransaction())
+			{
+				var invoice = new InvoiceWithAddress
+				{
+					Issued = DateTime.Now,
+					BillingAddress = new Address { Line = "84 rue du 22 septembre", City = "Courbevoie", ZipCode = "92400", Country = "France" }
+				};
+				session.Save(invoice);
+				transaction.Commit();
+			}
+
+			using (ISession session = OpenSession())
+			{
+				var invoices = session.CreateCriteria<Invoice>().List<Invoice>();
+			}
+		}
+
+		protected override void OnTearDown()
+		{
+			base.OnTearDown();
+			using (ISession session = OpenSession())
+			{
+				session.CreateQuery("delete from InvoiceWithAddress").ExecuteUpdate();
+				session.Flush();
+			}
+		}
+	}
+}

src/NHibernate.Test/NHSpecificTest/NH1904/StructMappings.hbm.xml

@@ -0,0 +1,22 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<hibernate-mapping xmlns="urn:nhibernate-mapping-2.2"
+    assembly="NHibernate.Test"
+    namespace="NHibernate.Test.NHSpecificTest.NH1904">
+
+  <class name="InvoiceWithAddress">
+    <id name="ID" type="Int32">
+      <generator class="hilo" />
+    </id>
+
+    <property name="Issued" type="DateTime" />
+
+    <component name="BillingAddress">
+      <property name="Line"/>
+      <property name="Line2"/>
+      <property name="City"/>
+      <property name="ZipCode"/>
+      <property name="Country"/>
+    </component>
+  </class>
+
+</hibernate-mapping>

src/NHibernate.Test/NHibernate.Test.csproj

@@ -742,6 +742,7 @@
     <Compile Include="NHSpecificTest\EntityWithUserTypeCanHaveLinqGenerators\FooExample.cs" />
     <Compile Include="NHSpecificTest\EntityWithUserTypeCanHaveLinqGenerators\IExample.cs" />
     <Compile Include="Insertordering\NH3931Entities.cs" />
+    <Compile Include="NHSpecificTest\NH1904\StructFixture.cs" />
     <Compile Include="NHSpecificTest\NH3247\Entity.cs" />
     <Compile Include="NHSpecificTest\NH3247\Fixture.cs" />
     <Compile Include="NHSpecificTest\NH3386\Entity.cs" />
@@ -3251,6 +3252,7 @@
     <EmbeddedResource Include="NHSpecificTest\NH1291AnonExample\Mappings.hbm.xml" />
   </ItemGroup>
   <ItemGroup>
+    <EmbeddedResource Include="NHSpecificTest\NH1904\StructMappings.hbm.xml" />
     <EmbeddedResource Include="Insertordering\FamilyModel\Mappings.hbm.xml" />
     <EmbeddedResource Include="Insertordering\AnimalModel\Mappings.hbm.xml" />
     <EmbeddedResource Include="NHSpecificTest\NH3247\Mappings.hbm.xml" />

src/NHibernate/Properties/BasicPropertyAccessor.cs

@@ -130,22 +130,8 @@ internal static BasicSetter GetSetterOrNull(System.Type type, string propertyNam
 				return null;
 			}
 
-			// According to http://msdn.microsoft.com/EN-US/library/kz0a8sxy%28v=VS.110,d=hv.2%29.aspx
-			// the assumption articulated in the comment following "if(type.IsValueType)" is wrong at least since .NET 2.0!
-			// This part of the code has beed changed twice to fix the following Issues in order: NH-1728 then NH-1904
-			// As it stands now the implementation prevents AliasToBeanTransformer from finding the correct property 
-			// on a class if the dialect returns column names in a different case than expected.
-
 			BindingFlags bindingFlags = BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.DeclaredOnly;
 
-			if (type.IsValueType)
-			{
-				// the BindingFlags.IgnoreCase is important here because if type is a struct, the GetProperty method does
-				// not ignore case by default. If type is a class, it _does_ ignore case... we're better off explicitly
-				// stating that casing should be ignored so we get the same behavior for both structs and classes
-				bindingFlags = bindingFlags | BindingFlags.IgnoreCase;
-			}
-
 			PropertyInfo property = type.GetProperty(propertyName, bindingFlags);
 
 			if (property != null && property.CanWrite)