Fixes #3713: query cache result transformer aliases issue #3714
+102
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Member
There was a problem hiding this comment.
This PR targets the 5.5.x branch. Fixes for bugs which are not regressions introduced in a supported version (5.5.x and 5.6.x as of now) should usually target the master branch.
It looks like this bug dates back to #2943, a 5.3.x change.
This said, the change is very simple and looks safe, so why not still putting this in 5.5.4, if other maintainers agree.
| [Test] | ||
| public void QueryCacheWithAliasToBeanTransformer() | ||
| { | ||
| const string query = "select s.id_ as Id from Simple as s;"; |
Member
There was a problem hiding this comment.
This causes the test to fail for Oracle, which does not support statements ending with a semi-colon. Can you rewrite the test with a HQL query instead? It would let NHibernate handles this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this is the most elegant way to solve the issue, but it does solve it, at least for the case I found.
I'm not sure if other Loader sub-classes also need something similar.
fix #3713