Merge pull request #31 from nd-02110114/fix-test-exmaple

nissy-dev · web-flow · commit 3737ee5270b0 · 2020-04-07T14:40:09.000+09:00
Refactor test and fix Line feed code
diff --git a/example/.babelrc b/example/.babelrc
diff --git a/example/input.js b/example/input.js
diff --git a/example/output.js b/example/output.js
diff --git a/package.json b/package.json
@@ -1,13 +1,12 @@
 {
   "name": "babel-plugin-object-to-json-parse",
-  "version": "0.0.9",
+  "version": "0.1.0",
   "main": "dist/index.js",
   "scripts": {
     "build": "rm -rf dist/** && tsc",
-    "example": "babel example/input.js -o example/output.js && node example/output.js",
     "fmt": "prettier --write \"src/**/*.ts\"",
     "lint": "eslint 'src/**/*.ts' --fix",
-    "test": "jest"
+    "test": "ls test/__fixtures__/**/*.js | xargs -L1 node && jest"
   },
   "dependencies": {
     "@babel/core": "^7.7.7",
@@ -48,7 +47,8 @@
     }
   },
   "lint-staged": {
-    "src/**/*.ts": ["yarn lint", "yarn fmt", "git add"]
+    "src/**/*.ts": ["yarn lint", "yarn fmt", "git add"],
+    "test/**/*.ts": ["yarn lint", "yarn fmt", "git add"]
   },
   "author": "nd-02110114 <nd.12021218@gmail.com>",
   "license": "MIT",
diff --git a/src/utils.ts b/src/utils.ts
@@ -66,9 +66,21 @@ export function converter(node: object | null | undefined): unknown {
   }
 
   if (isStringLiteral(node)) {
-    const { value } = node
+    let { value } = node
+    if (/\\/.test(value)) {
+      value = value.replace(/\\/g, '\\\\')
+    }
+
     if (/"/.test(value)) {
-      return value.replace(/"/g, '\\"')
+      value = value.replace(/"/g, '\\"')
+    }
+
+    if (/[\t\f\r\n\b]/g.test(value)) {
+      const codes = ['\t', '\f', '\r', '\n', '\t', '\b']
+      const replaceCodes = ['\\t', '\\f', '\\r', '\\n', '\\t', '\\b']
+      for (let i = 0; i < codes.length; i++) {
+        value = value.replace(new RegExp(codes[i]), replaceCodes[i])
+      }
     }
 
     return value
diff --git a/test/__fixtures__/array/input.js b/test/__fixtures__/array/input.js
@@ -0,0 +1,3 @@
+const test1 = [1, "two", {three: 3}]
+const test2 = [{one: 1}, {two: 2}, {three: 3}]
+const res = [test1, test2]
diff --git a/test/__fixtures__/array/output.js b/test/__fixtures__/array/output.js
@@ -0,0 +1,3 @@
+const test1 = JSON.parse('[1,"two",{"three":3}]')
+const test2 = JSON.parse('[{"one":1},{"two":2},{"three":3}]')
+const res = [test1, test2]
diff --git a/test/__fixtures__/object/array/input.js b/test/__fixtures__/object/array/input.js
@@ -0,0 +1,3 @@
+const test1 = { foo: [null, 10, 'foo'] }
+const test2 = { foo: [null, [10, 2], [{ foo: 'foo' }]] }
+const res = [test1, test2]
diff --git a/test/__fixtures__/object/array/output.js b/test/__fixtures__/object/array/output.js
@@ -0,0 +1,3 @@
+const test1 = JSON.parse('{"foo":[null,10,"foo"]}')
+const test2 = JSON.parse('{"foo":[null,[10,2],[{"foo":"foo"}]]}')
+const res = [test1, test2]
diff --git a/test/__fixtures__/object/backslash/input.js b/test/__fixtures__/object/backslash/input.js
@@ -0,0 +1,32 @@
+const test1 = { foo: "fo\'o" }
+const test2 = { foo: "fo\"o" }
+const test3 = { foo: 'fo\"o' }
+const test4 = { foo: 'fo\'o' }
+const test5 = { foo: 'fo\to' }
+const test6 = { foo: 'fo\fo' }
+const test7 = { foo: 'fo\ro' }
+const test8 = { foo: 'fo\no' }
+const test9 = { foo: 'fo\bo' }
+const test10 = { foo: 'fo\r\no' }
+const test11 = { foo: 'fo\o' }
+const test12 = { foo: 'fo\\o' }
+const test13 = { foo: 'fo\\\o' }
+const test14 = { foo: 'fo\\\\o' }
+const test15 = { foo: '\\\\' }
+const res = [
+  test1,
+  test2,
+  test3,
+  test4,
+  test5,
+  test6,
+  test7,
+  test8,
+  test9,
+  test10,
+  test11,
+  test12,
+  test13,
+  test14,
+  test15
+]
diff --git a/test/__fixtures__/object/backslash/output.js b/test/__fixtures__/object/backslash/output.js
@@ -0,0 +1,32 @@
+const test1 = JSON.parse('{"foo":"fo\'o"}')
+const test2 = JSON.parse('{"foo":"fo\\"o"}')
+const test3 = JSON.parse('{"foo":"fo\\"o"}')
+const test4 = JSON.parse('{"foo":"fo\'o"}')
+const test5 = JSON.parse('{"foo":"fo\\to"}')
+const test6 = JSON.parse('{"foo":"fo\\fo"}')
+const test7 = JSON.parse('{"foo":"fo\\ro"}')
+const test8 = JSON.parse('{"foo":"fo\\no"}')
+const test9 = JSON.parse('{"foo":"fo\\bo"}')
+const test10 = JSON.parse('{"foo":"fo\\r\\no"}')
+const test11 = JSON.parse('{"foo":"foo"}')
+const test12 = JSON.parse('{"foo":"fo\\\\o"}')
+const test13 = JSON.parse('{"foo":"fo\\\\o"}')
+const test14 = JSON.parse('{"foo":"fo\\\\\\\\o"}')
+const test15 = JSON.parse('{"foo":"\\\\\\\\"}')
+const res = [
+  test1,
+  test2,
+  test3,
+  test4,
+  test5,
+  test6,
+  test7,
+  test8,
+  test9,
+  test10,
+  test11,
+  test12,
+  test13,
+  test14,
+  test15
+]
diff --git a/test/__fixtures__/object/boolean/input.js b/test/__fixtures__/object/boolean/input.js
@@ -0,0 +1,2 @@
+const test1 = { foo: true }
+const res = [test1]
diff --git a/test/__fixtures__/object/boolean/output.js b/test/__fixtures__/object/boolean/output.js
@@ -0,0 +1,2 @@
+const test1 = JSON.parse('{"foo":true}')
+const res = [test1]
diff --git a/test/__fixtures__/object/invalid/input.js b/test/__fixtures__/object/invalid/input.js
@@ -0,0 +1,4 @@
+const test1 = { method(arg) { return arg }, b: 1 }
+const test2 = { ...test1, b: 1 }
+const test3 = { b : 'b_val', ['c']: 'c_val' }
+const test4 = { 77777777777777777.1: 'foo' }
diff --git a/test/__fixtures__/object/invalid/output.js b/test/__fixtures__/object/invalid/output.js
@@ -0,0 +1,15 @@
+const test1 = {
+  method(arg) {
+    return arg
+  },
+
+  b: 1
+}
+const test2 = { ...test1, b: 1 }
+const test3 = {
+  b: 'b_val',
+  ['c']: 'c_val'
+}
+const test4 = {
+  77777777777777777.1: 'foo'
+}
diff --git a/test/__fixtures__/object/null/input.js b/test/__fixtures__/object/null/input.js
@@ -0,0 +1,2 @@
+const test1 = { foo: null }
+const res = [test1]
diff --git a/test/__fixtures__/object/null/output.js b/test/__fixtures__/object/null/output.js
@@ -0,0 +1,2 @@
+const test1 = JSON.parse('{"foo":null}')
+const res = [test1]
diff --git a/test/__fixtures__/object/number/input.js b/test/__fixtures__/object/number/input.js
@@ -0,0 +1,2 @@
+const test1 = { foo: 10 }
+const res = [test1]
diff --git a/test/__fixtures__/object/number/output.js b/test/__fixtures__/object/number/output.js
@@ -0,0 +1,2 @@
+const test1 = JSON.parse('{"foo":10}')
+const res = [test1]
diff --git a/test/__fixtures__/object/object/input.js b/test/__fixtures__/object/object/input.js
@@ -0,0 +1,3 @@
+const test1 = { foo: { bar: 1337 } }
+const test2 = { 1: "123", 23: 45, b: "b_val" }
+const res = [test1, test2]
diff --git a/test/__fixtures__/object/object/output.js b/test/__fixtures__/object/object/output.js
@@ -0,0 +1,3 @@
+const test1 = JSON.parse('{"foo":{"bar":1337}}')
+const test2 = JSON.parse('{"1":"123","23":45,"b":"b_val"}')
+const res = [test1, test2]
diff --git a/test/__fixtures__/object/string/input.js b/test/__fixtures__/object/string/input.js
@@ -0,0 +1,5 @@
+const test1 = { foo: 'foo' }
+const test2 = { foo: "foo" }
+const test3 = { foo: "fo'o" }
+const test4 = { foo: 'fo"o' }
+const res = [test1, test2, test3, test4]
diff --git a/test/__fixtures__/object/string/output.js b/test/__fixtures__/object/string/output.js
@@ -0,0 +1,5 @@
+const test1 = JSON.parse('{"foo":"foo"}')
+const test2 = JSON.parse('{"foo":"foo"}')
+const test3 = JSON.parse('{"foo":"fo\'o"}')
+const test4 = JSON.parse('{"foo":"fo\\"o"}')
+const res = [test1, test2, test3, test4]
diff --git a/test/array_expression.test.ts b/test/array_expression.test.ts
@@ -0,0 +1,28 @@
+import pluginTester from 'babel-plugin-tester'
+import { buildPlugin } from '../src/plugin'
+import { ArrayExpression } from '../src/visitors/array_expression'
+
+pluginTester({
+  plugin: buildPlugin([ArrayExpression]),
+  filename: __filename,
+  pluginOptions: {
+    minJSONStringSize: 0,
+  },
+  tests: [
+    {
+      title: 'array',
+      fixture: '__fixtures__/array/input.js',
+      outputFixture: '__fixtures__/array/output.js',
+    },
+    {
+      title: 'array',
+      code: `const a = [1, "two", {three: 3}]`,
+      output: `const a = JSON.parse('[1,"two",{"three":3}]')`
+    },
+    {
+      title: 'array',
+      code: `const a = [{one: 1}, {two: 2}, {three: 3}]`,
+      output: `const a = JSON.parse('[{"one":1},{"two":2},{"three":3}]')`
+    },
+  ]
+})
diff --git a/test/e2e.test.ts b/test/e2e.test.ts
@@ -0,0 +1,66 @@
+import * as fs from 'fs'
+import * as path from 'path'
+import * as babel from '@babel/core'
+
+import plugin from '../src'
+
+
+const options = {
+  plugins: [
+    [plugin, { minJSONStringSize: 0}]
+  ],
+}
+
+const getter = (code: string | null | undefined) => new Function(`
+  ${code}
+  return res
+`)
+
+const pathToFixtures = {
+  'string': '__fixtures__/object/string/input.js',
+  'number': '__fixtures__/object/number/input.js',
+  'boolean': '__fixtures__/object/boolean/input.js',
+  'null': '__fixtures__/object/null/input.js',
+  'object': '__fixtures__/object/object/input.js',
+  'array': '__fixtures__/object/array/input.js',
+  'backslash': '__fixtures__/object/backslash/input.js',
+}
+
+// see: https://github.com/jamiebuilds/babel-handbook/blob/master/translations/en/plugin-handbook.md#exec-tests
+describe('This is end to end test (runtime checking)', () => {
+  it('string', () => {
+    const input = fs.readFileSync(path.join(__dirname, pathToFixtures['string']), {encoding: 'utf-8'});
+    const result = babel.transform(input, options)
+    expect(getter(input)()).toEqual(getter(result?.code)())
+  });
+  it('number', () => {
+    const input = fs.readFileSync(path.join(__dirname, pathToFixtures['number']), {encoding: 'utf-8'});
+    const result = babel.transform(input, options)
+    expect(getter(input)()).toEqual(getter(result?.code)())
+  });
+  it('boolean', () => {
+    const input = fs.readFileSync(path.join(__dirname, pathToFixtures['boolean']), {encoding: 'utf-8'});
+    const result = babel.transform(input, options)
+    expect(getter(input)()).toEqual(getter(result?.code)())
+  });
+  it('null', () => {
+    const input = fs.readFileSync(path.join(__dirname, pathToFixtures['null']), {encoding: 'utf-8'});
+    const result = babel.transform(input, options)
+    expect(getter(input)()).toEqual(getter(result?.code)())
+  });
+  it('object', () => {
+    const input = fs.readFileSync(path.join(__dirname, pathToFixtures['object']), {encoding: 'utf-8'});
+    const result = babel.transform(input, options)
+    expect(getter(input)()).toEqual(getter(result?.code)())
+  });
+  it('array', () => {
+    const input = fs.readFileSync(path.join(__dirname, pathToFixtures['array']), {encoding: 'utf-8'});
+    const result = babel.transform(input, options)
+    expect(getter(input)()).toEqual(getter(result?.code)())
+  });
+  it('backslash', () => {
+    const input = fs.readFileSync(path.join(__dirname, pathToFixtures['backslash']), {encoding: 'utf-8'});
+    const result = babel.transform(input, options)
+    expect(getter(input)()).toEqual(getter(result?.code)())
+  });
+})
diff --git a/test/object_expression.test.ts b/test/object_expression.test.ts
diff --git a/test/visitors/array_expression.test.ts b/test/visitors/array_expression.test.ts
diff --git a/test/visitors/object_expression.test.ts b/test/visitors/object_expression.test.ts
diff --git a/typings/babel-plugin-tester/index.d.ts b/typings/babel-plugin-tester/index.d.ts

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+const test1 = [1, "two", {three: 3}]`
	`2`	`+const test2 = [{one: 1}, {two: 2}, {three: 3}]`
	`3`	`+const res = [test1, test2]`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+const test1 = JSON.parse('[1,"two",{"three":3}]')`
	`2`	`+const test2 = JSON.parse('[{"one":1},{"two":2},{"three":3}]')`
	`3`	`+const res = [test1, test2]`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+const test1 = { foo: [null, 10, 'foo'] }`
	`2`	`+const test2 = { foo: [null, [10, 2], [{ foo: 'foo' }]] }`
	`3`	`+const res = [test1, test2]`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+const test1 = JSON.parse('{"foo":[null,10,"foo"]}')`
	`2`	`+const test2 = JSON.parse('{"foo":[null,[10,2],[{"foo":"foo"}]]}')`
	`3`	`+const res = [test1, test2]`