Add block property in Append children api response

Author: KoditkarVedant

Src/Notion.Client/Api/Blocks/AppendChildren/BlocksClient.cs

@@ -0,0 +1,25 @@
+using System;
+using System.Threading;
+using System.Threading.Tasks;
+
+namespace Notion.Client
+{
+    public sealed partial class BlocksClient
+    {
+        public async Task<AppendChildrenResponse> AppendChildrenAsync(
+            BlockAppendChildrenRequest request,
+            CancellationToken cancellationToken = default)
+        {
+            if (string.IsNullOrWhiteSpace(request.BlockId))
+            {
+                throw new ArgumentNullException(nameof(request.BlockId));
+            }
+
+            var url = ApiEndpoints.BlocksApiUrls.AppendChildren(request.BlockId);
+
+            var body = (IBlockAppendChildrenBodyParameters)request;
+
+            return await _client.PatchAsync<AppendChildrenResponse>(url, body, cancellationToken: cancellationToken);
+        }
+    }
+}

…Params/BlocksAppendChildrenParameters.cs …en/Request/BlockAppendChildrenRequest.csSrc/Notion.Client/Api/Blocks/RequestParams/BlocksAppendChildrenParameters.cs renamed to Src/Notion.Client/Api/Blocks/AppendChildren/Request/BlockAppendChildrenRequest.cs Src/Notion.Client/Api/Blocks/RequestParams/BlocksAppendChildrenParameters.cs renamed to Src/Notion.Client/Api/Blocks/AppendChildren/Request/BlockAppendChildrenRequest.cs

@@ -2,10 +2,12 @@
 
 namespace Notion.Client
 {
-    public class BlocksAppendChildrenParameters : IBlocksAppendChildrenBodyParameters
+    public class BlockAppendChildrenRequest : IBlockAppendChildrenBodyParameters, IBlockAppendChildrenPathParameters
     {
         public IEnumerable<IBlock> Children { get; set; }
 
         public string After { get; set; }
+
+        public string BlockId { get; set; }
     }
 }

…s/IBlocksAppendChildrenBodyParameters.cs …st/IBlockAppendChildrenBodyParameters.csSrc/Notion.Client/Api/Blocks/RequestParams/IBlocksAppendChildrenBodyParameters.cs renamed to Src/Notion.Client/Api/Blocks/AppendChildren/Request/IBlockAppendChildrenBodyParameters.cs Src/Notion.Client/Api/Blocks/RequestParams/IBlocksAppendChildrenBodyParameters.cs renamed to Src/Notion.Client/Api/Blocks/AppendChildren/Request/IBlockAppendChildrenBodyParameters.cs

@@ -4,7 +4,7 @@
 namespace Notion.Client
 {
     // TODO: need an input version of Block
-    public interface IBlocksAppendChildrenBodyParameters
+    public interface IBlockAppendChildrenBodyParameters
     {
         [JsonProperty("children")]
         IEnumerable<IBlock> Children { get; set; }

Src/Notion.Client/Api/Blocks/AppendChildren/Request/IBlockAppendChildrenPathParameters.cs

@@ -0,0 +1,7 @@
+namespace Notion.Client
+{
+    public interface IBlockAppendChildrenPathParameters
+    {
+        public string BlockId { get; set; }
+    }
+}

Src/Notion.Client/Api/Blocks/AppendChildren/Response/AppendChildrenResponse.cs

@@ -0,0 +1,11 @@
+using System.Collections.Generic;
+using Newtonsoft.Json;
+
+namespace Notion.Client
+{
+    public class AppendChildrenResponse : PaginatedList<IBlock>
+    {
+        [JsonProperty("block")]
+        public Dictionary<string, object> Block { get; set; }
+    }
+}

Src/Notion.Client/Api/Blocks/BlocksClient.cs

@@ -15,22 +15,6 @@ public BlocksClient(IRestClient client)
             _client = client;
         }
 
-        public async Task<PaginatedList<IBlock>> AppendChildrenAsync(
-            string blockId,
-            BlocksAppendChildrenParameters parameters = null, CancellationToken cancellationToken = default)
-        {
-            if (string.IsNullOrWhiteSpace(blockId))
-            {
-                throw new ArgumentNullException(nameof(blockId));
-            }
-
-            var url = BlocksApiUrls.AppendChildren(blockId);
-
-            var body = (IBlocksAppendChildrenBodyParameters)parameters;
-
-            return await _client.PatchAsync<PaginatedList<IBlock>>(url, body, cancellationToken: cancellationToken);
-        }
-
         public async Task<IBlock> RetrieveAsync(string blockId, CancellationToken cancellationToken = default)
         {
             if (string.IsNullOrWhiteSpace(blockId))

Src/Notion.Client/Api/Blocks/IBlocksClient.cs

@@ -38,12 +38,13 @@ Task<RetrieveChildrenResponse> RetrieveChildrenAsync(
         /// <summary>
         ///     Creates and appends new children blocks to the parent block_id specified.
         /// </summary>
-        /// <param name="blockId">Identifier for a block</param>
-        /// <param name="parameters"></param>
+        /// <param name="request"></param>
+        /// <param name="cancellationToken"></param>
         /// <returns>A paginated list of newly created first level children block objects.</returns>
-        Task<PaginatedList<IBlock>> AppendChildrenAsync(
-            string blockId,
-            BlocksAppendChildrenParameters parameters = null, CancellationToken cancellationToken = default);
+        Task<AppendChildrenResponse> AppendChildrenAsync(
+            BlockAppendChildrenRequest request,
+            CancellationToken cancellationToken = default
+        );
 
         /// <summary>
         ///     Sets a Block object, including page blocks, to archived: true using the ID specified.

Test/Notion.IntegrationTests/IBlocksClientTests.cs

@@ -20,9 +20,9 @@ public async Task AppendChildrenAsync_AppendsBlocksGivenBlocks()
         );
 
         var blocks = await Client.Blocks.AppendChildrenAsync(
-            page.Id,
-            new BlocksAppendChildrenParameters
+            new BlockAppendChildrenRequest
             {
+                BlockId = page.Id,
                 Children = new List<IBlock>
                 {
                     new BreadcrumbBlock { Breadcrumb = new BreadcrumbBlock.Data() },
@@ -58,21 +58,21 @@ public async Task UpdateBlockAsync_UpdatesGivenBlock()
         );
 
         var blocks = await Client.Blocks.AppendChildrenAsync(
-            page.Id,
-            new BlocksAppendChildrenParameters
+            new BlockAppendChildrenRequest
             {
+                BlockId = page.Id,
                 Children = new List<IBlock> { new BreadcrumbBlock { Breadcrumb = new BreadcrumbBlock.Data() } }
             }
         );
 
         var blockId = blocks.Results.First().Id;
         await Client.Blocks.UpdateAsync(blockId, new BreadcrumbUpdateBlock());
 
-        blocks = await Client.Blocks.RetrieveChildrenAsync(new BlockRetrieveChildrenRequest
+        var updatedBlocks = await Client.Blocks.RetrieveChildrenAsync(new BlockRetrieveChildrenRequest
         {
             BlockId = page.Id
         });
-        blocks.Results.Should().HaveCount(1);
+        updatedBlocks.Results.Should().HaveCount(1);
 
         // cleanup
         await Client.Pages.UpdateAsync(page.Id, new PagesUpdateParameters { Archived = true });
@@ -88,9 +88,9 @@ public async Task DeleteAsync_DeleteBlockWithGivenId()
         );
 
         var blocks = await Client.Blocks.AppendChildrenAsync(
-            page.Id,
-            new BlocksAppendChildrenParameters
+            new BlockAppendChildrenRequest
             {
+                BlockId = page.Id,
                 Children = new List<IBlock>
                 {
                     new DividerBlock { Divider = new DividerBlock.Data() },
@@ -117,20 +117,23 @@ public async Task UpdateAsync_UpdatesGivenBlock(
         );
 
         var blocks = await Client.Blocks.AppendChildrenAsync(
-            page.Id,
-            new BlocksAppendChildrenParameters { Children = new List<IBlock> { block } }
+            new BlockAppendChildrenRequest
+            {
+                BlockId = page.Id,
+                Children = new List<IBlock> { block }
+            }
         );
 
         var blockId = blocks.Results.First().Id;
         await Client.Blocks.UpdateAsync(blockId, updateBlock);
 
-        blocks = await Client.Blocks.RetrieveChildrenAsync(new BlockRetrieveChildrenRequest
+        var updatedBlocks = await Client.Blocks.RetrieveChildrenAsync(new BlockRetrieveChildrenRequest
         {
             BlockId = page.Id
         });
-        blocks.Results.Should().HaveCount(1);
+        updatedBlocks.Results.Should().HaveCount(1);
 
-        var updatedBlock = blocks.Results.First();
+        var updatedBlock = updatedBlocks.Results.First();
 
         assert.Invoke(updatedBlock, Client);
 

Test/Notion.UnitTests/BlocksClientTests.cs

@@ -60,8 +60,9 @@ public async Task AppendBlockChildren()
                     .WithBody(jsonData)
             );
 
-        var parameters = new BlocksAppendChildrenParameters
+        var request = new BlockAppendChildrenRequest
         {
+            BlockId = blockId,
             Children = new List<IBlock>
             {
                 new HeadingTwoBlock
@@ -100,7 +101,7 @@ public async Task AppendBlockChildren()
         };
 
         // Act
-        var blocksResult = await _client.AppendChildrenAsync(blockId, parameters);
+        var blocksResult = await _client.AppendChildrenAsync(request);
 
         // Assert
         var blocks = blocksResult.Results;