Skip to content

Commit eacd4f0

Browse files
author
Zihlu Wang
committed
refactor(simple-jwt): Optimised the code performance.
1 parent a670d97 commit eacd4f0

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

simple-jwt-jjwt/src/main/java/cn/org/codecrafters/simplejwt/jjwt/JjwtTokenResolver.java

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
import java.time.ZoneId;
4141
import java.util.Date;
4242
import java.util.Map;
43+
import java.util.Objects;
4344
import java.util.UUID;
4445

4546
/**
@@ -108,7 +109,7 @@ public class JjwtTokenResolver implements TokenResolver<Jws<Claims>> {
108109
private final JjwtTokenResolverConfig config = JjwtTokenResolverConfig.getInstance();
109110

110111
public JjwtTokenResolver(GuidCreator<?> jtiCreator, TokenAlgorithm algorithm, String issuer, String secret) {
111-
if (secret == null || secret.isBlank()) {
112+
if (Objects.isNull(secret) || secret.isBlank()) {
112113
throw new IllegalArgumentException("A secret is required to build a JSON Web Token.");
113114
}
114115

@@ -204,8 +205,7 @@ private String buildToken(Duration expireAfter, String audience, String subject,
204205
*/
205206
@Override
206207
public String createToken(Duration expireAfter, String audience, String subject) {
207-
var now = LocalDateTime.now();
208-
return buildToken(expireAfter, audience, subject, now, null);
208+
return buildToken(expireAfter, audience, subject, LocalDateTime.now(), null);
209209
}
210210

211211
/**
@@ -220,8 +220,7 @@ public String createToken(Duration expireAfter, String audience, String subject)
220220
*/
221221
@Override
222222
public String createToken(Duration expireAfter, String audience, String subject, Map<String, Object> payload) {
223-
var now = LocalDateTime.now();
224-
return buildToken(expireAfter, audience, subject, now, payload);
223+
return buildToken(expireAfter, audience, subject, LocalDateTime.now(), payload);
225224
}
226225

227226
/**
@@ -239,10 +238,9 @@ public String createToken(Duration expireAfter, String audience, String subject,
239238
*/
240239
@Override
241240
public <T extends TokenPayload> String createToken(Duration expireAfter, String audience, String subject, T payload) {
242-
var now = LocalDateTime.now();
243241
try {
244242
var claims = MapUtil.objectToMap(payload);
245-
return buildToken(expireAfter, audience, subject, now, claims);
243+
return buildToken(expireAfter, audience, subject, LocalDateTime.now(), claims);
246244
} catch (IllegalAccessException e) {
247245
log.error("An error occurs while accessing the fields of the object");
248246
}

0 commit comments

Comments
 (0)