Listen on ontrack event on Safari. (#337)

jianjunz · web-flow · commit bd0c9b6f490e · 2020-04-14T16:29:05.000+08:00
This commit only fixes issue for Safari. But we should eventually
remove event handlers for both onaddstream and onremovestream.
diff --git a/src/sdk/p2p/peerconnection-channel.js b/src/sdk/p2p/peerconnection-channel.js
@@ -657,7 +657,7 @@ class P2PPeerConnectionChannel extends EventDispatcher {
       this._pc.addTransceiver('audio');
       this._pc.addTransceiver('video');
     }
-    if (!this._isUnifiedPlan()) {
+    if (!this._isUnifiedPlan() && !Utils.isSafari()) {
       this._pc.onaddstream = (event) => {
         // TODO: Legacy API, should be removed when all UAs implemented WebRTC 1.0.
         this._onRemoteStreamAdded.apply(this, [event]);

Original file line number	Diff line number	Diff line change
`@@ -657,7 +657,7 @@ class P2PPeerConnectionChannel extends EventDispatcher {`
`657`	`657`	`this._pc.addTransceiver('audio');`
`658`	`658`	`this._pc.addTransceiver('video');`
`659`	`659`	`}`
`660`		`- if (!this._isUnifiedPlan()) {`
	`660`	`+ if (!this._isUnifiedPlan() && !Utils.isSafari()) {`
`661`	`661`	`this._pc.onaddstream = (event) => {`
`662`	`662`	`// TODO: Legacy API, should be removed when all UAs implemented WebRTC 1.0.`
`663`	`663`	`this._onRemoteStreamAdded.apply(this, [event]);`