Skip to content
This repository was archived by the owner on Oct 25, 2024. It is now read-only.

Commit bfae2f1

Browse files
committed
Fixed ESLint warnings with style/documentation affected
Signed-off-by: Geoff Gustafson <geoff@linux.intel.com>
1 parent 2051a5a commit bfae2f1

File tree

3 files changed

+21
-11
lines changed

3 files changed

+21
-11
lines changed

src/sdk/conference/signaling.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,7 @@ export class SioSignaling extends EventModule.EventDispatcher {
159159
* @function _onReconnectionTicket
160160
* @instance
161161
* @desc Parse reconnection ticket and schedule ticket refreshing.
162+
* @param {string} ticketString Reconnection ticket.
162163
* @memberof Owt.Conference.SioSignaling
163164
* @private.
164165
*/
@@ -189,6 +190,13 @@ export class SioSignaling extends EventModule.EventDispatcher {
189190
}, refreshAfter);
190191
}
191192

193+
/**
194+
* @function _clearReconnectionTask
195+
* @instance
196+
* @desc Stop trying to refresh reconnection ticket.
197+
* @memberof Owt.Conference.SioSignaling
198+
* @private.
199+
*/
192200
_clearReconnectionTask() {
193201
clearTimeout(this._refreshReconnectionTicket);
194202
this._refreshReconnectionTicket = null;

src/sdk/p2p/p2pclient.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,6 @@ const P2PClient = function(configuration, signalingChannel) {
153153
* @instance
154154
* @desc Disconnect from the signaling channel. It stops all existing sessions with remote endpoints.
155155
* @memberof Owt.P2P.P2PClient
156-
* @returns {Promise<undefined, Error>}
157156
*/
158157
this.disconnect = function() {
159158
if (state == ConnectionState.READY) {

src/sdk/p2p/peerconnection-channel.js

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -937,9 +937,11 @@ class P2PPeerConnectionChannel extends EventDispatcher {
937937

938938
_unpublish(stream) {
939939
if (navigator.mozGetUserMedia || !this._remoteSideSupportsRemoveStream) {
940-
// Actually unpublish is supported. It is a little bit complex since Firefox implemented WebRTC spec while Chrome implemented an old API.
940+
// Actually unpublish is supported. It is a little bit complex since
941+
// Firefox implemented WebRTC spec while Chrome implemented an old API.
941942
Logger.error(
942-
'Stopping a publication is not supported on Firefox. Please use P2PClient.stop() to stop the connection with remote endpoint.'
943+
'Stopping a publication is not supported on Firefox. Please use ' +
944+
'P2PClient.stop() to stop the connection with remote endpoint.'
943945
);
944946
return Promise.reject(new ErrorModule.P2PError(
945947
ErrorModule.errors.P2P_CLIENT_UNSUPPORTED_METHOD));
@@ -965,7 +967,8 @@ class P2PPeerConnectionChannel extends EventDispatcher {
965967
return;
966968
}
967969
if (!this._pc) {
968-
Logger.debug('PeerConnection is not available before creating DataChannel.');
970+
Logger.debug('PeerConnection is not available before creating ' +
971+
'DataChannel.');
969972
return;
970973
}
971974
Logger.debug('Create data channel.');
@@ -986,14 +989,14 @@ class P2PPeerConnectionChannel extends EventDispatcher {
986989
this._onDataChannelClose.apply(this, [event]);
987990
};
988991
dc.onerror = (event) => {
989-
Logger.debug('Data Channel Error:', error);
992+
Logger.debug('Data Channel Error: ' + event);
990993
};
991994
}
992995

993996
// Returns all MediaStreams it belongs to.
994997
_getStreamByTrack(mediaStreamTrack) {
995998
const streams = [];
996-
for (const [id, info] of this._remoteStreamInfo) {
999+
for (const [/* id */, info] of this._remoteStreamInfo) {
9971000
if (!info.stream || !info.stream.mediaStream) {
9981001
continue;
9991002
}
@@ -1021,22 +1024,22 @@ class P2PPeerConnectionChannel extends EventDispatcher {
10211024
promiseError = new ErrorModule.P2PError(
10221025
ErrorModule.errors.P2P_CLIENT_UNKNOWN);
10231026
}
1024-
for (const [label, dc] of this._dataChannels) {
1027+
for (const [/* label */, dc] of this._dataChannels) {
10251028
dc.close();
10261029
}
10271030
this._dataChannels.clear();
10281031
if (this._pc && this._pc.iceConnectionState !== 'closed') {
10291032
this._pc.close();
10301033
}
1031-
for (const [id, promise] of this._publishPromises) {
1034+
for (const [/* id */, promise] of this._publishPromises) {
10321035
promise.reject(promiseError);
10331036
}
10341037
this._publishPromises.clear();
1035-
for (const [id, promise] of this._unpublishPromises) {
1038+
for (const [/* id */, promise] of this._unpublishPromises) {
10361039
promise.reject(promiseError);
10371040
}
10381041
this._unpublishPromises.clear();
1039-
for (const [id, promise] of this._sendDataPromises) {
1042+
for (const [/* id */, promise] of this._sendDataPromises) {
10401043
promise.reject(promiseError);
10411044
}
10421045
this._sendDataPromises.clear();
@@ -1088,7 +1091,7 @@ class P2PPeerConnectionChannel extends EventDispatcher {
10881091
_checkIceConnectionStateAndFireEvent() {
10891092
if (this._pc.iceConnectionState === 'connected' ||
10901093
this._pc.iceConnectionState === 'completed') {
1091-
for (const [id, info] of this._remoteStreamInfo) {
1094+
for (const [/* id */, info] of this._remoteStreamInfo) {
10921095
if (info.mediaStream) {
10931096
const streamEvent = new StreamModule.StreamEvent('streamadded', {
10941097
stream: info.stream,

0 commit comments

Comments
 (0)