Rust: Issue #13453 - Empty enum variant names (#13454)

Author: jacob-pro

modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractRustCodegen.java

@@ -173,6 +173,11 @@ public String toModelDocFilename(String name) {
 
     @Override
     public String toEnumVarName(String name, String datatype) {
+        // Empty strings need to be mapped to "Empty"
+        // https://github.com/OpenAPITools/openapi-generator/issues/13453
+        if (Strings.isNullOrEmpty(name)) {
+            return "Empty";
+        }
         // Rust Enum variants should be camel cased
         return sanitizeIdentifier(name, CasingType.CAMEL_CASE, "variant", "enum variant", true);
     }

modules/openapi-generator/src/test/java/org/openapitools/codegen/rust/AbstractRustCodegenTest.java

@@ -117,6 +117,9 @@ public void testToEnumVarName() {
         Assert.assertEquals(fakeRustCodegen.toEnumVarName("SCREAMING_SNAKE_CASE", null), "ScreamingSnakeCase");
         // Prefix is added when starting with a number
         Assert.assertEquals(fakeRustCodegen.toEnumVarName("1_pending", null), "Variant1Pending");
+        // Empty strings need to be mapped to "Empty"
+        // https://github.com/OpenAPITools/openapi-generator/issues/13453
+        Assert.assertEquals(fakeRustCodegen.toEnumVarName("", null), "Empty");
     }
 
     @Test

modules/openapi-generator/src/test/resources/3_0/rust/petstore.yaml

@@ -812,9 +812,11 @@ components:
           - $ref: '#/components/schemas/Baz'
           - nullable: false
     Baz:
+      description: Test handling of empty variants
       enum:
       - A
       - B
+      - ""
       type: string
     TypeTesting:
       description: Test handling of different field data types

samples/client/petstore/rust/.openapi-generator/VERSION

@@ -8,14 +8,17 @@
  * Generated by: https://openapi-generator.tech
  */
 
+/// Baz : Test handling of empty variants
 
-/// 
+/// Test handling of empty variants
 #[derive(Clone, Copy, Debug, Eq, PartialEq, Ord, PartialOrd, Hash, Serialize, Deserialize)]
 pub enum Baz {
     #[serde(rename = "A")]
     A,
     #[serde(rename = "B")]
     B,
+    #[serde(rename = "")]
+    Empty,
 
 }
 
@@ -24,6 +27,7 @@ impl ToString for Baz {
         match self {
             Self::A => String::from("A"),
             Self::B => String::from("B"),
+            Self::Empty => String::from(""),
         }
     }
 }

samples/client/petstore/rust/docs/InlineObject.md

@@ -8,14 +8,17 @@
  * Generated by: https://openapi-generator.tech
  */
 
+/// Baz : Test handling of empty variants
 
-/// 
+/// Test handling of empty variants
 #[derive(Clone, Copy, Debug, Eq, PartialEq, Ord, PartialOrd, Hash, Serialize, Deserialize)]
 pub enum Baz {
     #[serde(rename = "A")]
     A,
     #[serde(rename = "B")]
     B,
+    #[serde(rename = "")]
+    Empty,
 
 }
 
@@ -24,6 +27,7 @@ impl ToString for Baz {
         match self {
             Self::A => String::from("A"),
             Self::B => String::from("B"),
+            Self::Empty => String::from(""),
         }
     }
 }

samples/client/petstore/rust/docs/InlineObject1.md

@@ -8,14 +8,17 @@
  * Generated by: https://openapi-generator.tech
  */
 
+/// Baz : Test handling of empty variants
 
-/// 
+/// Test handling of empty variants
 #[derive(Clone, Copy, Debug, Eq, PartialEq, Ord, PartialOrd, Hash, Serialize, Deserialize)]
 pub enum Baz {
     #[serde(rename = "A")]
     A,
     #[serde(rename = "B")]
     B,
+    #[serde(rename = "")]
+    Empty,
 
 }
 
@@ -24,6 +27,7 @@ impl ToString for Baz {
         match self {
             Self::A => String::from("A"),
             Self::B => String::from("B"),
+            Self::Empty => String::from(""),
         }
     }
 }

samples/client/petstore/rust/hyper/petstore/src/models/baz.rs

@@ -8,14 +8,17 @@
  * Generated by: https://openapi-generator.tech
  */
 
+/// Baz : Test handling of empty variants
 
-/// 
+/// Test handling of empty variants
 #[derive(Clone, Copy, Debug, Eq, PartialEq, Ord, PartialOrd, Hash, Serialize, Deserialize)]
 pub enum Baz {
     #[serde(rename = "A")]
     A,
     #[serde(rename = "B")]
     B,
+    #[serde(rename = "")]
+    Empty,
 
 }
 
@@ -24,6 +27,7 @@ impl ToString for Baz {
         match self {
             Self::A => String::from("A"),
             Self::B => String::from("B"),
+            Self::Empty => String::from(""),
         }
     }
 }