Get ready for adding more verification tasks

Author: mgencur

tests/e2e/hcp_external_cluster_backup_restore_suite_test.go

@@ -2,6 +2,7 @@ package e2e_test
 
 import (
 	"context"
+	"errors"
 	"time"
 
 	"github.com/onsi/ginkgo/v2"
@@ -13,6 +14,10 @@ import (
 	libhcp "github.com/openshift/oadp-operator/tests/e2e/lib/hcp"
 )
 
+const (
+	testNamespace = "test"
+)
+
 // External cluster backup and restore tests will skip creating HostedCluster resource. They expect the cluster
 // to already have HostedCluster with a data plane.
 // The tests are skipped unless hc_backup_restore_mode flag is properly configured.
@@ -76,24 +81,38 @@ var _ = ginkgo.Describe("HCP external cluster Backup and Restore tests", ginkgo.
 })
 
 func preBackupVerifyGuest() VerificationFunctionGuest {
-	return func(crClientGuest client.Client, namespace string) error {
-		ns := &corev1.Namespace{}
-		ns.Name = "test"
-		err := crClientGuest.Create(context.Background(), ns)
-		if err != nil && !apierrors.IsAlreadyExists(err) {
-			return err
-		}
-		return nil
+	return func(crClientGuest client.Client, _ string) error {
+		var errs []error
+		errs = append(errs, createTestNamespace(crClientGuest))
+		// Add more verifications here if needed
+		return errors.Join(errs...)
 	}
 }
 
 func postBackupVerifyGuest() VerificationFunctionGuest {
-	return func(crClientGuest client.Client, namespace string) error {
-		ns := &corev1.Namespace{}
-		err := crClientGuest.Get(context.Background(), client.ObjectKey{Name: "test"}, ns)
-		if err != nil {
-			return err
-		}
-		return nil
+	return func(crClientGuest client.Client, _ string) error {
+		var errs []error
+		errs = append(errs, validateTestNamespace(crClientGuest))
+		// Add more verifications here if needed
+		return errors.Join(errs...)
+	}
+}
+
+func createTestNamespace(crClientGuest client.Client) error {
+	ns := &corev1.Namespace{}
+	ns.Name = testNamespace
+	err := crClientGuest.Create(context.Background(), ns)
+	if err != nil && !apierrors.IsAlreadyExists(err) {
+		return err
+	}
+	return nil
+}
+
+func validateTestNamespace(crClientGuest client.Client) error {
+	ns := &corev1.Namespace{}
+	err := crClientGuest.Get(context.Background(), client.ObjectKey{Name: testNamespace}, ns)
+	if err != nil {
+		return err
 	}
+	return nil
 }