acornett21 review

PascalBourdier · PascalBourdier · commit a9ee12389fbd · 2025-12-02T08:07:26.000+01:00
Signed-off-by: Pascal Bourdier &lt;pascal.bourdier@gmail.com&gt;
diff --git a/internal/plugins/helm/v1/api.go b/internal/plugins/helm/v1/api.go
@@ -235,5 +235,8 @@ func (p *createAPISubcommand) Scaffold(fs machinery.Filesystem) error {
 
 // hasDifferentCRDVersion returns true if any other CRD version is tracked in the project configuration.
 func hasDifferentAPIVersion(versions []string, version string) bool {
-	return len(versions) != 0 && (len(versions) != 1 || versions[0] != version)
+	if len(versions) == 0 {
+		return false
+	}
+	return len(versions) > 1 || versions[0] != version
 }

Original file line number	Diff line number	Diff line change
`@@ -235,5 +235,8 @@ func (p *createAPISubcommand) Scaffold(fs machinery.Filesystem) error {`
`235`	`235`
`236`	`236`	`// hasDifferentCRDVersion returns true if any other CRD version is tracked in the project configuration.`
`237`	`237`	`func hasDifferentAPIVersion(versions []string, version string) bool {`
`238`		`- return len(versions) != 0 && (len(versions) != 1 \|\| versions[0] != version)`
	`238`	`+ if len(versions) == 0 {`
	`239`	`+ return false`
	`240`	`+ }`
	`241`	`+ return len(versions) > 1 \|\| versions[0] != version`
`239`	`242`	`}`