Skip to content

Commit 22bc716

Browse files
committed
Fix multiple links in Javadoc
1 parent c314caa commit 22bc716

File tree

10 files changed

+42
-33
lines changed

10 files changed

+42
-33
lines changed

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/method/StaticmethodBuiltins.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ protected PNone init(VirtualFrame frame, PDecoratedMethod self, Object callable,
122122
@GenerateNodeFactory
123123
abstract static class GetNode extends DescrGetBuiltinNode {
124124
/**
125-
* @see ClassmethodBuiltins.GetNode#getCached
125+
* @see ClassmethodCommonBuiltins.GetNode#getCached
126126
*/
127127
@Specialization(guards = {"isSingleContext()", "cachedSelf == self", "cachedCallable != null"}, limit = "3")
128128
static Object getCached(@SuppressWarnings("unused") PDecoratedMethod self, @SuppressWarnings("unused") Object obj, @SuppressWarnings("unused") Object type,

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/object/ObjectBuiltins.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@
9090
import com.oracle.graal.python.builtins.objects.set.SetBuiltins;
9191
import com.oracle.graal.python.builtins.objects.str.StringNodes.CastToTruffleStringChecked0Node;
9292
import com.oracle.graal.python.builtins.objects.str.StringNodes.CastToTruffleStringChecked1Node;
93-
import com.oracle.graal.python.builtins.objects.thread.ThreadLocalBuiltins;
9493
import com.oracle.graal.python.builtins.objects.type.PythonBuiltinClass;
9594
import com.oracle.graal.python.builtins.objects.type.PythonManagedClass;
9695
import com.oracle.graal.python.builtins.objects.type.TpSlots;
@@ -509,9 +508,10 @@ public abstract static class GetAttributeNode extends GetAttrBuiltinNode {
509508
@Child private ReadAttributeFromObjectNode attrRead;
510509

511510
/**
512-
* Keep in sync with {@link TypeBuiltins.GetattributeNode} and
513-
* {@link ThreadLocalBuiltins.GetAttributeNode} and
514-
* {@link MergedObjectTypeModuleGetAttributeNode}
511+
* Keep in sync with
512+
* {@link com.oracle.graal.python.builtins.objects.type.TypeBuiltins.GetattributeNode} and
513+
* {@link com.oracle.graal.python.builtins.objects.thread.ThreadLocalBuiltins.GetAttributeNode}
514+
* and {@link MergedObjectTypeModuleGetAttributeNode}
515515
*/
516516
@Specialization
517517
@SuppressWarnings("truffle-static-method")

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/str/StringBuiltins.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -206,8 +206,7 @@
206206

207207
/**
208208
* NOTE: self can either be a TruffleString, PString, PythonNativeObject string or a foreign string
209-
* (isString()). Use {@link CastToTruffleStringCheckedNode} or {@link CastToTruffleStringNode} to
210-
* convert to TruffleString.
209+
* (isString()). Use {@link CastToTruffleStringNode} to convert to TruffleString.
211210
*/
212211
@CoreFunctions(extendClasses = PythonBuiltinClassType.PString)
213212
public final class StringBuiltins extends PythonBuiltins {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/str/StringUtils.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -586,9 +586,9 @@ public static int getCodePoint(String characterName) {
586586
}
587587

588588
/**
589-
* Like {@link TruffleString.EqualNode} but with the proper {@link InliningCutoff} since
590-
* {@link TruffleString.EqualNode} is too big for host inlining, at least when used in node
591-
* guards.
589+
* Like {@link com.oracle.truffle.api.strings.TruffleString.EqualNode} but with the proper
590+
* {@link InliningCutoff} since {@link com.oracle.truffle.api.strings.TruffleString.EqualNode}
591+
* is too big for host inlining, at least when used in node guards.
592592
*/
593593
@GenerateInline
594594
@GenerateCached(false)

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/thread/ThreadLocalBuiltins.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@
6262
import com.oracle.graal.python.builtins.objects.str.StringNodes.CastToTruffleStringChecked1Node;
6363
import com.oracle.graal.python.builtins.objects.type.TpSlots;
6464
import com.oracle.graal.python.builtins.objects.type.TpSlots.GetObjectSlotsNode;
65-
import com.oracle.graal.python.builtins.objects.type.TypeBuiltins;
6665
import com.oracle.graal.python.builtins.objects.type.TypeNodes;
6766
import com.oracle.graal.python.builtins.objects.type.slots.TpSlot;
6867
import com.oracle.graal.python.builtins.objects.type.slots.TpSlotDescrGet.CallSlotDescrGet;
@@ -139,8 +138,10 @@ public abstract static class GetAttributeNode extends GetAttrBuiltinNode {
139138
@Child private CallSlotDescrGet callGetNode;
140139

141140
/**
142-
* Keep in sync with {@link ObjectBuiltins.GetAttributeNode} and
143-
* {@link TypeBuiltins.GetattributeNode} and {@link MergedObjectTypeModuleGetAttributeNode}
141+
* Keep in sync with
142+
* {@link com.oracle.graal.python.builtins.objects.object.ObjectBuiltins.GetAttributeNode}
143+
* and {@link com.oracle.graal.python.builtins.objects.type.TypeBuiltins.GetattributeNode}
144+
* and {@link MergedObjectTypeModuleGetAttributeNode}
144145
*/
145146
@Specialization
146147
Object doIt(VirtualFrame frame, PThreadLocal object, Object keyObj,

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/type/TypeBuiltins.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -99,15 +99,13 @@
9999
import com.oracle.graal.python.builtins.objects.function.PKeyword;
100100
import com.oracle.graal.python.builtins.objects.getsetdescriptor.DescriptorDeleteMarker;
101101
import com.oracle.graal.python.builtins.objects.list.PList;
102-
import com.oracle.graal.python.builtins.objects.object.ObjectBuiltins;
103102
import com.oracle.graal.python.builtins.objects.object.ObjectNodes;
104103
import com.oracle.graal.python.builtins.objects.set.PSet;
105104
import com.oracle.graal.python.builtins.objects.set.SetBuiltins.UpdateSingleNode;
106105
import com.oracle.graal.python.builtins.objects.str.PString;
107106
import com.oracle.graal.python.builtins.objects.str.StringNodes.CastToTruffleStringChecked0Node;
108107
import com.oracle.graal.python.builtins.objects.str.StringNodes.CastToTruffleStringChecked1Node;
109108
import com.oracle.graal.python.builtins.objects.str.StringUtils.SimpleTruffleStringFormatNode;
110-
import com.oracle.graal.python.builtins.objects.thread.ThreadLocalBuiltins;
111109
import com.oracle.graal.python.builtins.objects.tuple.PTuple;
112110
import com.oracle.graal.python.builtins.objects.type.TpSlots.GetCachedTpSlotsNode;
113111
import com.oracle.graal.python.builtins.objects.type.TpSlots.GetObjectSlotsNode;
@@ -528,9 +526,11 @@ public abstract static class GetattributeNode extends GetAttrBuiltinNode {
528526
@Child private LookupAttributeInMRONode.Dynamic lookupAsClass;
529527

530528
/**
531-
* Keep in sync with {@link ObjectBuiltins.GetAttributeNode} and
532-
* {@link ThreadLocalBuiltins.GetAttributeNode} and
533-
* {@link MergedObjectTypeModuleGetAttributeNode}
529+
* Keep in sync with
530+
* {@link com.oracle.graal.python.builtins.objects.object.ObjectBuiltins.GetAttributeNode}
531+
* and
532+
* {@link com.oracle.graal.python.builtins.objects.thread.ThreadLocalBuiltins.GetAttributeNode}
533+
* and {@link MergedObjectTypeModuleGetAttributeNode}
534534
*/
535535
@Specialization
536536
protected Object doIt(VirtualFrame frame, Object object, Object keyObj,

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/compiler/bytecode_dsl/RootNodeCompiler.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -827,8 +827,9 @@ public BytecodeDSLCompilerResult compileFunctionDef(StmtTy node, String name, Ar
827827

828828
/**
829829
* Creates a code unit that will create the type parameters and invoke "make function" with
830-
* given code unit to create the function for the {@link StmtTy.FunctionDef} or
831-
* {@link StmtTy.AsyncFunctionDef} that we are processing.
830+
* given code unit to create the function for the
831+
* {@link com.oracle.graal.python.pegparser.sst.StmtTy.FunctionDef} or
832+
* {@link com.oracle.graal.python.pegparser.sst.StmtTy.AsyncFunctionDef} that we are processing.
832833
* <p/>
833834
* The resulting code unit will take the values of the default arguments and default keyword
834835
* arguments of the function we are processing as its own arguments. The values of those

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/attributes/MergedObjectTypeModuleGetAttributeNode.java

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@
4848
import com.oracle.graal.python.builtins.objects.module.PythonModule;
4949
import com.oracle.graal.python.builtins.objects.object.ObjectBuiltins;
5050
import com.oracle.graal.python.builtins.objects.str.StringNodes.CastToTruffleStringChecked1Node;
51-
import com.oracle.graal.python.builtins.objects.thread.ThreadLocalBuiltins;
5251
import com.oracle.graal.python.builtins.objects.type.TpSlots;
5352
import com.oracle.graal.python.builtins.objects.type.TpSlots.GetCachedTpSlotsNode;
5453
import com.oracle.graal.python.builtins.objects.type.TpSlots.GetObjectSlotsNode;
@@ -77,9 +76,11 @@
7776
import com.oracle.truffle.api.strings.TruffleString;
7877

7978
/**
80-
* A node merging the logic of {@link ObjectBuiltins.GetAttributeNode},
81-
* {@link TypeBuiltins.GetattributeNode} and {@link ModuleBuiltins.ModuleGetattributeNode} to reduce
82-
* code size by about 3x for host inlining
79+
* A node merging the logic of
80+
* {@link com.oracle.graal.python.builtins.objects.object.ObjectBuiltins.GetAttributeNode},
81+
* {@link com.oracle.graal.python.builtins.objects.type.TypeBuiltins.GetattributeNode} and
82+
* {@link com.oracle.graal.python.builtins.objects.module.ModuleBuiltins.ModuleGetattributeNode} to
83+
* reduce code size by about 3x for host inlining
8384
*/
8485
@GenerateUncached
8586
@GenerateInline
@@ -109,9 +110,12 @@ abstract class MergedObjectTypeModuleGetAttributeInnerNode extends PNodeWithCont
109110
public abstract Object execute(VirtualFrame frame, Node inliningTarget, Object object, TruffleString key, Object type, TpSlots slots);
110111

111112
/**
112-
* Keep in sync with {@link ObjectBuiltins.GetAttributeNode} and
113-
* {@link TypeBuiltins.GetattributeNode} and {@link ThreadLocalBuiltins.GetAttributeNode} and
114-
* {@link ModuleBuiltins.ModuleGetattributeNode}
113+
* Keep in sync with
114+
* {@link com.oracle.graal.python.builtins.objects.object.ObjectBuiltins.GetAttributeNode} and
115+
* {@link com.oracle.graal.python.builtins.objects.type.TypeBuiltins.GetattributeNode} and
116+
* {@link com.oracle.graal.python.builtins.objects.thread.ThreadLocalBuiltins.GetAttributeNode}
117+
* and
118+
* {@link com.oracle.graal.python.builtins.objects.module.ModuleBuiltins.ModuleGetattributeNode}
115119
*/
116120
@Specialization(guards = {"slots.tp_getattro() == cachedSlot", "isObjectTypeModuleGetAttribute(cachedSlot)"}, limit = "1")
117121
static Object doIt(VirtualFrame frame, Node inliningTarget, Object object, TruffleString key, Object type, @SuppressWarnings("unused") TpSlots slots,

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/object/IsNode.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@
4747
import com.oracle.graal.python.builtins.objects.code.PCode;
4848
import com.oracle.graal.python.builtins.objects.ints.PInt;
4949
import com.oracle.graal.python.builtins.objects.str.PString;
50-
import com.oracle.graal.python.builtins.objects.str.StringNodes;
5150
import com.oracle.graal.python.builtins.objects.type.PythonBuiltinClass;
5251
import com.oracle.graal.python.nodes.PGuards;
5352
import com.oracle.graal.python.nodes.bytecode.PBytecodeGeneratorFunctionRootNode;
@@ -290,7 +289,10 @@ private static boolean doPNoneSlowpath(Object left, Object right, Node inliningT
290289
}
291290

292291
// pstring (may be interned)
293-
/** See {@link StringNodes.InternStringNode} and {@link StringNodes.IsInternedStringNode} */
292+
/**
293+
* See {@link com.oracle.graal.python.builtins.objects.str.StringNodes.InternStringNode} and
294+
* {@link com.oracle.graal.python.builtins.objects.str.StringNodes.IsInternedStringNode}
295+
*/
294296
@Specialization
295297
public static boolean doPString(PString left, PString right) {
296298
if (left == right) {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/ExecutionContext.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -292,15 +292,17 @@ protected static void prepareCall(VirtualFrame frame, Object[] callArguments, No
292292
* Execution of a Python function should be wrapped with {@link #enter(VirtualFrame)} and
293293
* {@link #exit(VirtualFrame, PRootNode)}.
294294
* <p>
295-
* When entering the function we create the {@link PFrame.Reference} that represents the current
296-
* (possibly not yet materialized virtual frame). From then on, at any point we can refer to the
297-
* current {@link PFrame.Reference} instance if we have the current virtual frame at hand.
295+
* When entering the function we create the
296+
* {@link com.oracle.graal.python.builtins.objects.frame.PFrame.Reference} that represents the
297+
* current (possibly not yet materialized virtual frame). From then on, at any point we can
298+
* refer to the current {@link com.oracle.graal.python.builtins.objects.frame.PFrame.Reference}
299+
* instance if we have the current virtual frame at hand.
298300
* <p>
299301
* When leaving the function, we check if the current frame needs to outlive the function
300302
* execution, i.e., needs to escape. In such case, the frame is materialized to a {@link PFrame}
301303
* instance, and we copy local variables and some arguments into a new {@link MaterializedFrame}
302304
* stored in the {@link PFrame} (see {@link MaterializeFrameNode}). The {@link PFrame} is stored
303-
* into {@link PFrame.Reference}.
305+
* into {@link com.oracle.graal.python.builtins.objects.frame.PFrame.Reference}.
304306
* <p>
305307
* The frame may have been matarialized already during the function execution, in such case we
306308
* just synchronize the existing {@link PFrame} with the virtual frame when leaving the

0 commit comments

Comments
 (0)