Skip to content

Commit 51f9df8

Browse files
committed
Wait for pgo profiles in post merge bench jobs
1 parent ebc12db commit 51f9df8

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

ci.jsonnet

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -297,6 +297,8 @@
297297
}),
298298
},
299299

300+
local need_pgo = task_spec({runAfter: ["python-pgo-profile-post_merge-linux-amd64-jdk-latest"]}),
301+
local need_bc_pgo = task_spec({runAfter: ["python-pgo-profile-bytecode-dsl-post_merge-linux-amd64-jdk-latest"]}),
300302
local forks_warmup = forks("./mx.graalpython/warmup-fork-counts.json"),
301303
local forks_meso = forks("meso.json"),
302304
local raw_results = task_spec({
@@ -313,7 +315,7 @@
313315
local bench_task_dict = {
314316
[bench]: bench_task(bench) + platform_spec(no_jobs) + bench_variants({
315317
"vm_name:graalvm_ce_default" : {"linux:amd64:jdk-latest" : on_demand + t("08:00:00")},
316-
"vm_name:graalvm_ee_default" : {"linux:amd64:jdk-latest" : post_merge + t("08:00:00")},
318+
"vm_name:graalvm_ee_default" : {"linux:amd64:jdk-latest" : post_merge + t("08:00:00") + need_pgo},
317319
"vm_name:graalpython_core" : {"linux:amd64:jdk-latest" : on_demand + t("08:00:00")},
318320
"vm_name:graalpython_enterprise" : {"linux:amd64:jdk-latest" : daily + t("08:00:00"),
319321
"job_type:checkup" : {"linux:amd64:jdk-latest" : on_demand + t("08:00:00")}
@@ -332,7 +334,7 @@
332334
} + {
333335
[bench]: bench_task(bench) + platform_spec(no_jobs) + bench_variants({
334336
"vm_name:graalvm_ce_default" : {"linux:amd64:jdk-latest" : on_demand + t("08:00:00")},
335-
"vm_name:graalvm_ee_default" : {"linux:amd64:jdk-latest" : post_merge + t("08:00:00")},
337+
"vm_name:graalvm_ee_default" : {"linux:amd64:jdk-latest" : post_merge + t("08:00:00") + need_pgo},
336338
"vm_name:graalpython_core" : {"linux:amd64:jdk-latest" : on_demand + t("08:00:00")},
337339
"vm_name:graalpython_core_panama" : {"linux:amd64:jdk-latest" : on_demand + t("08:00:00")},
338340
"vm_name:graalpython_enterprise" : {"linux:amd64:jdk-latest" : daily + t("08:00:00"),
@@ -399,14 +401,14 @@
399401
for bench in ["warmup"]
400402
} + {
401403
[bench]: bench_task(bench) + platform_spec(no_jobs) + bench_variants({
402-
"vm_name:graalvm_ee_default_interpreter" : {"linux:amd64:jdk-latest" : post_merge + t("02:00:00")},
404+
"vm_name:graalvm_ee_default_interpreter" : {"linux:amd64:jdk-latest" : post_merge + t("02:00:00") + need_pgo},
403405
"vm_name:graalpython_enterprise_interpreter" : {"linux:amd64:jdk-latest" : weekly + t("02:00:00")},
404406
"vm_name:cpython" : {"linux:amd64:jdk-latest" : weekly + t("01:00:00")},
405407
}),
406408
for bench in ["heap", "micro_small_heap"]
407409
} + {
408410
[bench + "-bytecode-dsl"]: bench_task(bench) + bytecode_dsl_bench + platform_spec(no_jobs) + bench_variants({
409-
"vm_name:graalvm_ee_default_interpreter_bc_dsl" : {"linux:amd64:jdk-latest" : post_merge + t("02:00:00")},
411+
"vm_name:graalvm_ee_default_interpreter_bc_dsl" : {"linux:amd64:jdk-latest" : post_merge + t("02:00:00") + need_bc_pgo},
410412
"vm_name:graalpython_enterprise_interpreter_bc_dsl" : {"linux:amd64:jdk-latest" : weekly + t("02:00:00")},
411413
}),
412414
for bench in ["heap", "micro_small_heap"]

mx.graalpython/mx_graalpython.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@ def libpythonvm_build_args():
316316
# when running in the CI on a bench runner, ensure a PGO profile
317317
if (
318318
any(b.startswith("release/") for b in [branch, os.environ.get("TO_BRANCH", "")])
319-
or os.environ.get('BUILD_NAME', '').startswith('pybench-')
319+
or ("bench" in os.environ.get('BUILD_NAME', ''))
320320
):
321321
mx.warn("PGO profile must exist for benchmarking and release, creating one now...")
322322
profile = graalpy_native_pgo_build_and_test()

0 commit comments

Comments
 (0)