Skip to content

Commit 6c60fd7

Browse files
committed
Use CURRENT_PLATFORM as mx report suffix while running in GITHUB_CI
Fix merge reports TMP: Set retagger gate job goal to linux amd64/aarch64 on all batches
1 parent 7545908 commit 6c60fd7

File tree

5 files changed

+34
-21
lines changed

5 files changed

+34
-21
lines changed

.github/workflows/ci-unittest-retagger.yml

Lines changed: 21 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,33 +8,44 @@ jobs:
88
run-retagger:
99
uses: ./.github/workflows/ci-matrix-gen.yml
1010
with:
11-
jobs_to_run: python-svm-build-gate-linux|python-unittest-retagger-gate-batch1
11+
jobs_to_run: python-svm-build-gate-linux|python-unittest-retagger-gate
1212

1313
merge_all_reports:
1414
runs-on: ubuntu-latest
1515
needs: run-retagger
1616
if: ${{ success() }}
1717
steps:
18+
19+
- name: Actions/Checkout
20+
uses: actions/checkout@main
21+
with:
22+
path: main
23+
1824
- name: Download reports
1925
uses: actions/download-artifact@v5
2026
with:
2127
pattern: python-unittest-retagger*
2228
merge-multiple: true
2329
continue-on-error: true
30+
2431
- name: Merge retagger reports
2532
working-directory: main
2633
run: |
27-
mkdir -p ../retagger-reports
28-
sh -c mv retagger-report*.json ../retagger-reports
29-
cd ../retagger-reports
30-
python3 ../main/.github/scripts/merge_retagger_results.py
31-
cd ../main
32-
python3 ./graalpython/com.oracle.graal.python.test/src/runner.py merge-tags-from-report ../retagger-reports/reports-merged.json
33-
sh -c git diff >> reports_diff
34+
mkdir -p ../retagger-reports ../diffs
35+
ls && ls ..
36+
mv retagger-report*.json ../retagger-reports
37+
38+
declare -a os_list=("linux-x86_64" "linux-aarch64" "darwin-x86_64" "windows-x86_64")
39+
for os in "${os_list[@]}"; do
40+
echo "Merging tags for $os"
41+
python3 .github/scripts/merge_retagger_results.py --dir ../retagger-reports --outfile "../retagger-reports/reports-merged-$os.json" --pattern "*$os*" || true
42+
python3 graalpython/com.oracle.graal.python.test/src/runner.py merge-tags-from-report "../retagger-reports/reports-merged-$os.json" --platform "$os" || true
43+
git diff > "../diffs/reports_diff-$os" || true
44+
done
3445
3546
- name: Export reports diff file
3647
uses: actions/upload-artifact@v5
3748
with:
3849
name: retagger.diff
39-
path: main/diff_reports
40-
retention-days: 1
50+
path: diffs/reports_diff*
51+
retention-days: 15

ci/graal/common.json

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"Jsonnet files should not include this file directly but use ci/common.jsonnet instead."
55
],
66

7-
"mx_version": "7.67.0",
7+
"mx_version": "7.68.4",
88

99
"COMMENT.jdks": "When adding or removing JDKs keep in sync with JDKs in ci/common.jsonnet",
1010
"jdks": {
@@ -49,12 +49,12 @@
4949
"graalvm-ee-25-ea": {"name": "graalvm-jdk", "version": "25.0.0", "ea": "36", "platformspecific": true },
5050

5151
"oraclejdk-latest": {"name": "jpg-jdk", "version": "25", "build_id": "jdk-25.0.1+8", "platformspecific": true, "extrabundles": ["static-libs"]},
52-
"labsjdk-ce-latest": {"name": "labsjdk", "version": "ce-25.0.1+8-jvmci-25.1-b10", "platformspecific": true },
53-
"labsjdk-ce-latestDebug": {"name": "labsjdk", "version": "ce-25.0.1+8-jvmci-25.1-b10-debug", "platformspecific": true },
54-
"labsjdk-ce-latest-llvm": {"name": "labsjdk", "version": "ce-25.0.1+8-jvmci-25.1-b10-sulong", "platformspecific": true },
55-
"labsjdk-ee-latest": {"name": "labsjdk", "version": "ee-25.0.1+8-jvmci-25.1-b10", "platformspecific": true },
56-
"labsjdk-ee-latestDebug": {"name": "labsjdk", "version": "ee-25.0.1+8-jvmci-25.1-b10-debug", "platformspecific": true },
57-
"labsjdk-ee-latest-llvm": {"name": "labsjdk", "version": "ee-25.0.1+8-jvmci-25.1-b10-sulong", "platformspecific": true }
52+
"labsjdk-ce-latest": {"name": "labsjdk", "version": "ce-25.0.1+8-jvmci-25.1-b11", "platformspecific": true },
53+
"labsjdk-ce-latestDebug": {"name": "labsjdk", "version": "ce-25.0.1+8-jvmci-25.1-b11-debug", "platformspecific": true },
54+
"labsjdk-ce-latest-llvm": {"name": "labsjdk", "version": "ce-25.0.1+8-jvmci-25.1-b11-sulong", "platformspecific": true },
55+
"labsjdk-ee-latest": {"name": "labsjdk", "version": "ee-25.0.1+8-jvmci-25.1-b11", "platformspecific": true },
56+
"labsjdk-ee-latestDebug": {"name": "labsjdk", "version": "ee-25.0.1+8-jvmci-25.1-b11-debug", "platformspecific": true },
57+
"labsjdk-ee-latest-llvm": {"name": "labsjdk", "version": "ee-25.0.1+8-jvmci-25.1-b11-sulong", "platformspecific": true }
5858
},
5959

6060
"eclipse": {
@@ -69,4 +69,4 @@
6969
"pylint": "==2.4.4",
7070
"black": "==23.11.0"
7171
}
72-
}
72+
}

ci/python-gate.libsonnet

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,7 @@
341341
environment+: {
342342
TAGGED_UNITTEST_PARTIAL: "%d/%d" % [i, num],
343343
RETAGGER_BATCH_NO: i,
344-
MX_REPORT_SUFFIX: "_batch_%d_%s-%s" % [i, self.os, self.arch],
344+
MX_REPORT_SUFFIX: "_batch_%d" % [i],
345345
},
346346
variations+::["batch" + i]
347347
}),

graalpython/com.oracle.graal.python.test/src/runner.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -449,6 +449,8 @@ def generate_mx_report(self, path: str):
449449
# Some reports may be split when ran on github, this sets different file names
450450
report_suffix = os.environ.get("MX_REPORT_SUFFIX")
451451
if report_suffix:
452+
if os.environ.get("GITHUB_CI"):
453+
report_suffix = f"{report_suffix}_{CURRENT_PLATFORM}"
452454
tmppath, ext = os.path.splitext(path)
453455
path = f"{tmppath}{report_suffix}{ext}"
454456

mx.graalpython/suite.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,15 +53,15 @@
5353
},
5454
{
5555
"name": "tools",
56-
"version": "4eaa61399415a2602c8fca5a3efb2d5145c20b8b",
56+
"version": "e61a4623b7fc839ee10df84050c120d59056b871",
5757
"subdir": True,
5858
"urls": [
5959
{"url": "https://github.com/oracle/graal", "kind": "git"},
6060
],
6161
},
6262
{
6363
"name": "regex",
64-
"version": "4eaa61399415a2602c8fca5a3efb2d5145c20b8b",
64+
"version": "e61a4623b7fc839ee10df84050c120d59056b871",
6565
"subdir": True,
6666
"urls": [
6767
{"url": "https://github.com/oracle/graal", "kind": "git"},

0 commit comments

Comments
 (0)