Skip to content

Commit 759caa5

Browse files
committed
Fix bisection recursion
1 parent a327102 commit 759caa5

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

mx.graalpython/mx_graalpython_bisect.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,9 @@ def print_line(l):
7272
}
7373

7474

75-
def get_commit(repo_path: Path, ref='HEAD'):
76-
return GIT.git_command(repo_path, ['rev-parse', ref], abortOnError=True).strip()
75+
def get_commit(repo_path, ref='HEAD'):
76+
if repo_path:
77+
return GIT.git_command(repo_path, ['rev-parse', ref], abortOnError=True).strip()
7778

7879

7980
def get_message(repo_path: Path, commit):
@@ -127,11 +128,11 @@ def run_bisect_benchmark(repo_path: Path, bad, good, callback, good_result=None,
127128
downstream_bad = get_commit(downstream_repo_path)
128129
subresults = {}
129130
if downstream_bad and downstream_good and downstream_bad != downstream_good:
130-
GIT.update_to_branch(DIR, commits[good_index])
131+
GIT.update_to_branch(repo_path, commits[good_index])
131132
subresult = run_bisect_benchmark(downstream_repo_path, downstream_bad, downstream_good, callback, good_result,
132133
bad_result)
133134
subresults[bad_index] = subresult
134-
return BisectResult(downstream_repo_path, commits, results, good_index, bad_index, subresults)
135+
return BisectResult(repo_path, commits, results, good_index, bad_index, subresults)
135136

136137

137138
class BisectResult:

0 commit comments

Comments
 (0)