Skip to content

Commit f37d4fc

Browse files
committed
Use build type Release by default for C API
1 parent d31368f commit f37d4fc

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

graalpython/com.oracle.graal.python.cext/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,6 @@ endif()
113113

114114
# preprocessor defines for all platforms
115115
add_compile_definitions(
116-
NDEBUG
117116
WITH_FREELISTS=1
118117
)
119118

mx.graalpython/suite.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -670,6 +670,11 @@
670670
"libc": ["default"],
671671
},
672672
"cmakeConfig": {
673+
# Possible/useful build types:
674+
# "Release": highest opt level, no debugging symbols, no assertions, -DNDEBUG, etc.
675+
# "RelWithDebInfo": medium opt level, with debugging symbols, no assertions, -DNDEBUG
676+
# "Debug": no opt level, debugging symbols, assertions, ...
677+
"CMAKE_BUILD_TYPE": "Release",
673678
"CAPI_INC_DIR": "<output_root:com.oracle.graal.python>/jni_gen",
674679
"PYCONFIG_INCLUDE_DIR": "<output_root:graalpy-pyconfig>/<os>-<arch>/<multitarget_libc_selection>",
675680
"TRUFFLE_NFI_H_INC": "<path:com.oracle.truffle.nfi.native>/include",
@@ -701,6 +706,11 @@
701706
{"libc": ["musl"], "variant": ["swcfi"]},
702707
],
703708
"cmakeConfig": {
709+
# Possible/useful build types:
710+
# "Release": highest opt level (e.g. -O3, -lto), no debugging symbols, no assertions, -DNDEBUG, etc.
711+
# "RelWithDebInfo": medium opt level (e.g. -O2, -lto), with debugging symbols, no assertions, -DNDEBUG
712+
# "Debug": no opt level, debugging symbols, assertions, ...
713+
"CMAKE_BUILD_TYPE": "Release",
704714
"CAPI_INC_DIR": "<output_root:com.oracle.graal.python>/jni_gen",
705715
"PYCONFIG_INCLUDE_DIR": "<output_root:graalpy-pyconfig>/<os>-<arch>/<multitarget_libc_selection>/",
706716
"TRUFFLE_NFI_H_INC": "<path:com.oracle.truffle.nfi.native>/include",

0 commit comments

Comments
 (0)