release resources - Fortify

Author: thurka

visualvm/appui/src/org/graalvm/visualvm/modules/appui/AboutAction.java

@@ -98,6 +98,7 @@ private String getBuildNumber() {
             try {
                 InputStream manifestStream = getClass().getResourceAsStream("/META-INF/MANIFEST.MF"); // NOI18N
                 buildNumber = new Manifest(manifestStream).getMainAttributes().getValue("OpenIDE-Module-Implementation-Version"); // NOI18N
+                manifestStream.close();
             } catch (IOException ex) {}
         }
 

visualvm/libs.profiler/lib.profiler/src/org/graalvm/visualvm/lib/jfluid/heap/AbstractLongMap.java

@@ -100,6 +100,7 @@ abstract class Entry {
         }
         file.setLength(fileSize);
         setDumpBuffer(file);
+        file.close();
         cacheDirectory = cacheDir;
     }
 
@@ -216,6 +217,7 @@ void writeToStream(DataOutputStream out) throws IOException {
         fileSize = keys * ENTRY_SIZE;
         RandomAccessFile file = new RandomAccessFile(tempFile, "rw"); // NOI18N
         setDumpBuffer(file);
+        file.close();
         cacheDirectory = cacheDir;
     }
 
@@ -514,6 +516,7 @@ public void force(File bufferFile) throws IOException{
                     channel.write(buf);
                     offset_start = (int)(offset_end - (i+1)*BUFFER_SIZE);
                 }
+                channel.close();
                 dumpBuffer = null;
                 bufferFile.delete();
                 newBufferFile.renameTo(bufferFile);
@@ -535,6 +538,7 @@ private static MappedByteBuffer[] createBuffers(RandomAccessFile file, long leng
                 dumpBuffer[i] = channel.map(MemoryMappedData.MAP_MODE, position, size);
             }
             channel.close();
+            file.close();
             return dumpBuffer;
         }
     }

visualvm/libs.profiler/lib.profiler/src/org/graalvm/visualvm/lib/jfluid/heap/LongBuffer.java

@@ -201,6 +201,7 @@ LongBuffer revertBuffer() throws IOException {
                 raf.seek(offset);
                 reverted.writeLong(raf.readLong());
             }
+            raf.close();
         }
         reverted.startReading();
         return reverted;

visualvm/libs.profiler/lib.profiler/src/org/graalvm/visualvm/lib/jfluid/utils/FileOrZipEntry.java

@@ -140,8 +140,10 @@ public long getLength() throws IOException {
             return (new File(dirOrJar, fileName)).length();
         } else {
             ZipFile zip = new ZipFile(dirOrJar);
+            long size = zip.getEntry(fileName).getSize();
 
-            return zip.getEntry(fileName).getSize();
+            zip.close();
+            return size;
         }
     }
 

visualvm/libs.profiler/lib.profiler/src/org/graalvm/visualvm/lib/jfluid/utils/MiscUtils.java

@@ -157,24 +157,24 @@ public static void getAllClassesInJar(String jarName, boolean removeClassExt, Co
 
         try {
             zip = new ZipFile(jarName);
-        } catch (Exception ex) {
-            System.err.println("Warning: could not open archive " + jarName); // NOI18N
-
-            return;
-        }
+            for (Enumeration entries = zip.entries(); entries.hasMoreElements();) {
+                ZipEntry entry = (ZipEntry) entries.nextElement();
+                String className = entry.getName();
 
-        for (Enumeration entries = zip.entries(); entries.hasMoreElements();) {
-            ZipEntry entry = (ZipEntry) entries.nextElement();
-            String className = entry.getName();
+                if (className.endsWith(".class")) { // NOI18N
 
-            if (className.endsWith(".class")) { // NOI18N
+                    if (removeClassExt) {
+                        className = className.substring(0, className.length() - 6);
+                    }
 
-                if (removeClassExt) {
-                    className = className.substring(0, className.length() - 6);
+                    res.add(className.intern());
                 }
-
-                res.add(className.intern());
             }
+            zip.close();
+        } catch (Exception ex) {
+            System.err.println("Warning: could not open archive " + jarName); // NOI18N
+
+            return;
         }
     }
 
@@ -402,6 +402,7 @@ private static void getClassPathFromManifest(String jarPath,List pathList) throw
                     }
                 }
             }
+            jarFile.close();
         }
     }
 

visualvm/profiling/src/org/graalvm/visualvm/profiling/presets/ProfilerPresets.java

@@ -286,6 +286,7 @@ private static String getMainClass(Application application) {
                                     String mainClassName = jf.getManifest().getMainAttributes().getValue(Attributes.Name.MAIN_CLASS);
                                     assert mainClassName!=null;
                                     mainClass = mainClassName.replace('\\', '/').replace('/', '.'); // NOI18N
+                                    jf.close();
                                 } catch (IOException ex) {
     //                                LOGGER.log(Level.INFO, "getMainClass", ex);   // NOI18N
                                 }

visualvm/tools/src/org/graalvm/visualvm/tools/jvmstat/JvmJvmstatModel.java

@@ -258,6 +258,7 @@ public String getMainClass() {
                     JarFile jf = new JarFile(jarFile);
                     mainClassName = jf.getManifest().getMainAttributes().getValue(Attributes.Name.MAIN_CLASS);
                     assert mainClassName!=null;
+                    jf.close();
                 } catch (IOException ex) {
                     LOGGER.throwing(JvmJvmstatModel.class.getName(), "getMainClass", ex);   // NOI18N
                 }