Added remote::connect

Author: p-ranav

README.md

@@ -1233,8 +1233,8 @@ The project is available under the [MIT](https://opensource.org/licenses/MIT) li
 | --- | --- |
 | `git_remote_add_fetch` | `repository::add_fetch_refspec_to_remote` |
 | `git_remote_add_push` | `repository::add_push_refspec_to_remote` |
-| `git_remote_autotag` | **Not Implemented** |
-| `git_remote_connect` | **Not Implemented** |
+| `git_remote_autotag` | `remote::autotag_option` |
+| `git_remote_connect` | `remote::connect` |
 | `git_remote_connected` | `remote::is_connected` |
 | `git_remote_create` | `repository::create_remote` |
 | `git_remote_create_anonymous` | `repository::create_anonymous_remote` |

include/cppgit2/remote.hpp

@@ -1,5 +1,6 @@
 #pragma once
 #include <cppgit2/bitmask_operators.hpp>
+#include <cppgit2/connection_direction.hpp>
 #include <cppgit2/data_buffer.hpp>
 #include <cppgit2/fetch.hpp>
 #include <cppgit2/indexer.hpp>
@@ -31,6 +32,35 @@ class remote : public libgit2_api {
   // is connected to the remote host.
   bool is_connected() const;
 
+  class callbacks : public libgit2_api {
+  public:
+    callbacks() : c_ptr_(nullptr) {
+      auto ret = git_remote_init_callbacks(&default_options_,
+                                           GIT_REMOTE_CALLBACKS_VERSION);
+      c_ptr_ = &default_options_;
+      if (ret != 0)
+        throw git_exception();
+    }
+
+    callbacks(git_remote_callbacks *c_ptr) : c_ptr_(c_ptr) {}
+
+    // Access libgit2 C ptr
+    const git_remote_callbacks *c_ptr() const { return c_ptr_; }
+
+  private:
+    git_remote_callbacks *c_ptr_;
+    git_remote_callbacks default_options_;
+  };
+
+  // Open a connection to a remote
+  // The transport is selected based on the URL. The direction argument is due
+  // to a limitation of the git protocol (over TCP or SSH) which starts up a
+  // specific binary which can only do the one or the other.
+  void connect(connection_direction direction,
+               const callbacks &remote_callbacks = callbacks(),
+               const proxy::options &proxy_options = proxy::options(),
+               const strarray &custom_headers = strarray(nullptr));
+
   // Remote creation options flags
   enum class create_flag {
     // Ignore the repository apply.insteadOf configuration

src/remote.cpp

@@ -17,6 +17,16 @@ fetch::options::autotag remote::autotag_option() {
 
 bool remote::is_connected() const { return git_remote_connected(c_ptr_); }
 
+void remote::connect(connection_direction direction,
+                     const callbacks &remote_callbacks,
+                     const proxy::options &proxy_options,
+                     const strarray &custom_headers) {
+  if (git_remote_connect(c_ptr_, static_cast<git_direction>(direction),
+                         remote_callbacks.c_ptr(), proxy_options.c_ptr(),
+                         custom_headers.c_ptr()))
+    throw git_exception();
+}
+
 cppgit2::repository remote::create_options::repository() const {
   return cppgit2::repository(c_ptr_->repository);
 }