BUG: Use StrictVersion instead of LooseVersion when testing for minimum google api client version #10652

Author: parthea

doc/source/whatsnew/v0.17.0.txt

@@ -1146,3 +1146,4 @@ Bug Fixes
 - Bug in ``DatetimeIndex`` cannot infer negative freq (:issue:`11018`)
 - Remove use of some deprecated numpy comparison operations, mainly in tests. (:issue:`10569`)
 - Bug in ``Index`` dtype may not applied properly (:issue:`11017`)
+- Bug in ``io.gbq`` when testing for minimum google api client version (:issue:`10652`)

pandas/io/gbq.py

@@ -7,7 +7,7 @@
 
 import numpy as np
 
-from distutils.version import LooseVersion
+from distutils.version import StrictVersion
 from pandas import compat
 from pandas.core.api import DataFrame
 from pandas.tools.merge import concat
@@ -26,7 +26,7 @@ def _check_google_client_version():
 
     _GOOGLE_API_CLIENT_VERSION = pkg_resources.get_distribution('google-api-python-client').version
 
-    if LooseVersion(_GOOGLE_API_CLIENT_VERSION) < '1.2.0':
+    if StrictVersion(_GOOGLE_API_CLIENT_VERSION) < StrictVersion('1.2.0'):
         raise ImportError("pandas requires google-api-python-client >= 1.2.0 for Google "
                           "BigQuery support, current version " + _GOOGLE_API_CLIENT_VERSION)
 

pandas/io/tests/test_gbq.py

@@ -12,7 +12,7 @@
 
 import numpy as np
 
-from distutils.version import LooseVersion
+from distutils.version import StrictVersion
 from pandas import compat
 
 from pandas import NaT
@@ -65,7 +65,7 @@ def _test_imports():
                 _GOOGLE_API_CLIENT_INSTALLED=True
                 _GOOGLE_API_CLIENT_VERSION = pkg_resources.get_distribution('google-api-python-client').version
 
-                if LooseVersion(_GOOGLE_API_CLIENT_VERSION) >= '1.2.0':
+                if StrictVersion(_GOOGLE_API_CLIENT_VERSION) >= StrictVersion('1.2.0'):
                     _GOOGLE_API_CLIENT_VALID_VERSION = True
 
             except ImportError: