COMPAT: disable Series datetimeindex/periodindex methods introduced in (GH6380)

Author: jreback

pandas/core/base.py

@@ -261,12 +261,10 @@ def _wrap_access_object(self, obj):
 
     def max(self):
         """ The maximum value of the object """
-        self._is_allowed_index_op('max')
         return self.values.max()
 
     def min(self):
         """ The minimum value of the object """
-        self._is_allowed_index_op('min')
         return self.values.min()
 
     def value_counts(self, normalize=False, sort=True, ascending=False,

pandas/core/series.py

@@ -121,11 +121,15 @@ class Series(base.IndexOpsMixin, generic.NDFrame):
 
     @property
     def _allow_datetime_index_ops(self):
-        return self.index.is_all_dates and isinstance(self.index, DatetimeIndex)
+        # disabling to invalidate datetime index ops
+        # return self.index.is_all_dates and isinstance(self.index, DatetimeIndex)
+        return False
 
     @property
     def _allow_period_index_ops(self):
-        return self.index.is_all_dates and isinstance(self.index, PeriodIndex)
+        # disabling to invalidate period index ops
+        # return self.index.is_all_dates and isinstance(self.index, PeriodIndex)
+        return False
 
     def __init__(self, data=None, index=None, dtype=None, name=None,
                  copy=False, fastpath=False):

pandas/tests/test_base.py

@@ -452,7 +452,14 @@ def setUp(self):
 
     def test_ops_properties(self):
         self.check_ops_properties(['year','month','day','hour','minute','second','weekofyear','week','dayofweek','dayofyear','quarter'])
-        self.check_ops_properties(['date','time','microsecond','nanosecond', 'is_month_start', 'is_month_end', 'is_quarter_start', 'is_quarter_end', 'is_year_start', 'is_year_end'], lambda x: isinstance(x,DatetimeIndex))
+        self.check_ops_properties(['date','time','microsecond','nanosecond', 'is_month_start', 'is_month_end', 'is_quarter_start',
+                                   'is_quarter_end', 'is_year_start', 'is_year_end'], lambda x: isinstance(x,DatetimeIndex))
+
+    def test_ops_properties_basic(self):
+
+        # sanity check that the behavior didn't change
+        for op in ['year','day','second','weekday']:
+            self.assertRaises(TypeError, lambda x: getattr(self.dt_series,op))
 
 class TestPeriodIndexOps(Ops):
     _allowed = '_allow_period_index_ops'

pandas/tests/test_series.py

@@ -5619,7 +5619,9 @@ def test_asfreq(self):
 
     def test_weekday(self):
         # Just run the function
-        weekdays = self.ts.weekday
+        def f():
+            self.ts.weekday
+        self.assertRaises(TypeError, f)
 
     def test_diff(self):
         # Just run the function
@@ -5715,7 +5717,7 @@ def test_select(self):
         assert_series_equal(result, expected)
 
         result = self.ts.select(lambda x: x.weekday() == 2)
-        expected = self.ts[self.ts.weekday == 2]
+        expected = self.ts[self.ts.index.weekday == 2]
         assert_series_equal(result, expected)
 
 #------------------------------------------------------------------------------