TST: Fix assertion for TestSetitemNAPeriodDtype::expected #63069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
the
Testing
| exp = Series(period_range("2000-01-01", periods=10, freq="D")) | ||
| exp._values.view("i8")[key] = NaT._value | ||
| assert exp[key] is NaT or all(x is NaT for x in exp[key]) | ||
| assert exp[key] is NaT or any(x is NaT for x in exp) |
Member
There was a problem hiding this comment.
if this was passing before, does it suggest that exp[key] is NaT is always the case?
Member
Author
There was a problem hiding this comment.
Good point. Yeah I think then we can remove the or condition here
Member
Author
There was a problem hiding this comment.
So after removing the condition in ae2376a some jobs are failing to appears we do hit the second condition somtimes
Member
There was a problem hiding this comment.
i guess depending on key, exp[key] could be a scalar or non-scalar. In the non-scalar case, i would expect the existing all assertion to hold. why am i wrong?
Member
Author
There was a problem hiding this comment.
Ah OK I see now. I missed that key can be a slice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor, but I think
keyis a scalar soall(x is NaT for x in exp[key])wouldn't work sincePeriods are not iterable. Additionally, I think given the construction, theallassertion should be ananyassertion.