Allow passing Client as configuration option.

Prevent calling database creation if Client driver does not support QueryDriverInterface

Author: Steveb-p

InfluxDbStorage.php

@@ -59,10 +59,17 @@ public function __construct($config = 'influxdb:')
         if (empty($config)) {
             $config = [];
         } elseif (is_string($config)) {
-            $config = $this->parseDsn($config);
+            $config = self::parseDsn($config);
         } elseif (is_array($config)) {
-            $config = empty($config['dsn']) ? $config : $this->parseDsn($config['dsn']);
+            $config = empty($config['dsn']) ? $config : self::parseDsn($config['dsn']);
         } elseif ($config instanceof Client) {
+            // Passing Client instead of array config is deprecated because it prevents setting any configuration values
+            // and causes library to use defaults.
+            @trigger_error(
+                sprintf('Passing %s as %s argument is deprecated. Pass it as "client" array property or use createWithClient instead',
+                Client::class,
+                __METHOD__
+            ), E_USER_DEPRECATED);
             $this->client = $config;
             $config = [];
         } else {
@@ -97,6 +104,22 @@ public function __construct($config = 'influxdb:')
         $this->config = $config;
     }
 
+    /**
+     * @param Client $client
+     * @param string $config
+     *
+     * @return InfluxDbStorage
+     */
+    public static function createWithClient(Client $client, $config = 'influxdb:'): self
+    {
+        if (is_string($config)) {
+            $config = self::parseDsn($config);
+        }
+        $config['client'] = $client;
+
+        return new static($config);
+    }
+
     public function pushConsumerStats(ConsumerStats $stats): void
     {
         $points = [];
@@ -221,7 +244,7 @@ private function getDb(): Database
         return $this->database;
     }
 
-    private function parseDsn(string $dsn): array
+    private static function parseDsn(string $dsn): array
     {
         $dsn = Dsn::parseFirst($dsn);