always test with throttle plugin as all supported PHP versions are compatible now

Author: dbu

.github/workflows/continuous-integration.yml

@@ -34,7 +34,7 @@ jobs:
           - dependencies: "php-http/guzzle7-adapter"
             php-version: "8.2"
             symfony-deprecations-helper: "weak"
-          - dependencies: "php-http/guzzle7-adapter php-http/throttle-plugin"
+          - dependencies: "php-http/guzzle7-adapter"
             php-version: "8.3"
             symfony-deprecations-helper: "weak"
 

composer.json

@@ -42,11 +42,11 @@
         "symfony/options-resolver": "^6.4 || ^7.1"
     },
     "conflict": {
+        "kriswallsmith/buzz": "<0.17",
         "php-http/guzzle6-adapter": "<1.1",
         "php-http/cache-plugin": "<1.7",
         "php-http/curl-client": "<2.0",
         "php-http/socket-client": "<2.0",
-        "kriswallsmith/buzz": "<0.17",
         "php-http/react-adapter": "<3.0",
         "php-http/throttle-plugin": "<1.1"
     },
@@ -59,6 +59,7 @@
         "php-http/cache-plugin": "^1.7",
         "php-http/mock-client": "^1.2",
         "php-http/promise": "^1.0",
+        "php-http/throttle-plugin": "^1.1",
         "phpunit/phpunit": "^9",
         "symfony/browser-kit": "^6.4 || ^7.1",
         "symfony/cache": "^6.4 || ^7.1",

tests/Unit/DependencyInjection/HttplugExtensionTest.php

@@ -5,7 +5,6 @@
 namespace Http\HttplugBundle\Tests\Unit\DependencyInjection;
 
 use Http\Adapter\Guzzle7\Client;
-use Http\Client\Common\Plugin\ThrottlePlugin;
 use Http\Client\Plugin\Vcr\Recorder\InMemoryRecorder;
 use Http\HttplugBundle\Collector\PluginClientFactoryListener;
 use Http\HttplugBundle\DependencyInjection\HttplugExtension;
@@ -145,6 +144,11 @@ public function testClientPlugins(): void
                         [
                             'response_seekable_body' => true,
                         ],
+                        [
+                            'throttle' => [
+                                'name' => 'limiter.test',
+                            ],
+                        ],
                         [
                             'authentication' => [
                                 'my_basic' => [
@@ -168,13 +172,6 @@ public function testClientPlugins(): void
                 ],
             ],
         ];
-        if (class_exists(ThrottlePlugin::class)) {
-            $config['clients']['acme']['plugins'][] = [
-                'throttle' => [
-                    'name' => 'limiter.test',
-                ],
-            ];
-        }
 
         $this->load($config);
 
@@ -192,13 +189,11 @@ public function testClientPlugins(): void
             'httplug.client.acme.plugin.query_defaults',
             'httplug.client.acme.plugin.request_seekable_body',
             'httplug.client.acme.plugin.response_seekable_body',
+            'httplug.client.acme.plugin.throttle',
             'httplug.client.acme.authentication.my_basic',
             'httplug.client.acme.plugin.cache',
             'httplug.client.acme.plugin.error',
         ];
-        if (\class_exists(ThrottlePlugin::class)) {
-            $plugins[] = 'httplug.client.acme.plugin.throttle';
-        }
         $pluginReferences = array_map(fn ($id) => new Reference($id), $plugins);
 
         $this->assertContainerBuilderHasService('httplug.client.acme');