switch constructor and create signatures to be more compatible to IJsonSerializable #10

Author: gregor-j

src/Api/IMember.php

@@ -77,20 +77,20 @@ interface IMember extends IJsonSerializable
     public const JSON_NAME = 'name';
 
     /**
-     * API member constructor.
-     * @param string $type Either bool or in or float or ...
-     * @param string $name API struct or table member name.
+     * Initialize this class from an array.
+     * @param  array<string, string>  $array  Array containing the properties of this class.
      * @throws IInvalidArgumentException
      */
-    public function __construct(string $type, string $name);
+    public function __construct(array $array);
 
     /**
-     * Create an instance of this class from an array.
-     * @param  array<string, string>  $array  Array containing the properties of this class.
+     * Create an instance of this class.
+     * @param  string  $type  Member type. Use TYPE_* constants.
+     * @param  string  $name  API struct or table member name.
      * @return IMember
      * @throws IInvalidArgumentException
      */
-    public static function create(array $array): IMember;
+    public static function create(string $type, string $name): IMember;
 
     /**
      * The PHP type of the element.

src/Api/IStruct.php

@@ -60,22 +60,22 @@ interface IStruct extends IJsonSerializable
     public const JSON_MEMBERS = 'members';
 
     /**
-     * Table constructor.
-     * @param  string     $name        API struct name.
-     * @param  string     $direction   Either input or output
-     * @param  bool       $isOptional  Is the API struct optional?
-     * @param  IMember[]  $members     Array of members of the struct.
+     * Initialize this class from an array.
+     * @param  array<string, string|bool|array<string, string>>  $array  Array containing the properties of this class.
      * @throws IInvalidArgumentException
      */
-    public function __construct(string $name, string $direction, bool $isOptional, array $members);
+    public function __construct(array $array);
 
     /**
-     * Create an instance of this class from an array.
-     * @param  array<string, string|bool|array<string, string>>  $array  Array containing the properties of this class.
+     * Create an instance of this class.
+     * @param  string  $name  API struct name.
+     * @param  string  $direction  Either input or output
+     * @param  bool  $isOptional  Is the API struct optional?
+     * @param  IMember[]  $members  Array of members of the struct.
      * @return IStruct
      * @throws IInvalidArgumentException
      */
-    public static function create(array $array): IStruct;
+    public static function create(string $name, string $direction, bool $isOptional, array $members): IStruct;
 
     /**
      * The PHP type of the element.

src/Api/ITable.php

@@ -65,22 +65,22 @@ interface ITable extends IJsonSerializable
     public const JSON_MEMBERS = 'members';
 
     /**
-     * Table constructor.
-     * @param  string     $name        API table name.
-     * @param  string     $direction   Either input or output or table
-     * @param  bool       $isOptional  Is the API table optional?
-     * @param  IMember[]  $members     Array of members as columns of the table.
+     * Initialize this class from an array.
+     * @param  array<string, string|bool|array<string, string>>  $array  Array containing the properties of this class.
      * @throws IInvalidArgumentException
      */
-    public function __construct(string $name, string $direction, bool $isOptional, array $members);
+    public function __construct(array $array);
 
     /**
-     * Create an instance of this class from an array.
-     * @param  array<string, string|bool|array<string, string>>  $array  Array containing the properties of this class.
+     * Create an instance of this class.
+     * @param  string  $name  API table name.
+     * @param  string  $direction  Either input or output or table
+     * @param  bool  $isOptional  Is the API table optional?
+     * @param  IMember[]  $members  Array of members as columns of the table.
      * @return ITable
      * @throws IInvalidArgumentException
      */
-    public static function create(array $array): ITable;
+    public static function create(string $name, string $direction, bool $isOptional, array $members): ITable;
 
     /**
      * The PHP type of the element.

src/Api/IValue.php

@@ -97,22 +97,22 @@ interface IValue extends IJsonSerializable
     public const JSON_OPTIONAL = 'optional';
 
     /**
-     * API value constructor.
-     * @param string $type Either bool or in or float or ...
-     * @param string $name API value name.
-     * @param string $direction Either input or output.
-     * @param bool $isOptional Is the API value optional?
+     * Initialize this class from an array.
+     * @param  array<string, string|bool>  $array  Array containing the properties of this class.
      * @throws IInvalidArgumentException
      */
-    public function __construct(string $type, string $name, string $direction, bool $isOptional);
+    public function __construct(array $array);
 
     /**
-     * Create an instance of this class from an array.
-     * @param  array<string, string|bool>  $array  Array containing the properties of this class.
+     * Create an instance of this class.
+     * @param  string  $type  Either bool or in or float or ...
+     * @param  string  $name  API value name.
+     * @param  string  $direction  Either input or output.
+     * @param  bool  $isOptional  Is the API value optional?
      * @return IValue
      * @throws IInvalidArgumentException
      */
-    public static function create(array $array): IValue;
+    public static function create(string $type, string $name, string $direction, bool $isOptional): IValue;
 
     /**
      * The PHP type of the element.