Fix PropertiesExtension

ondrejmirtes · ondrejmirtes · commit 0209dd029675 · 2024-02-09T14:43:08.000+01:00
diff --git a/src/Rules/Doctrine/ORM/PropertiesExtension.php b/src/Rules/Doctrine/ORM/PropertiesExtension.php
@@ -7,7 +7,6 @@
 use PHPStan\Rules\Properties\ReadWritePropertiesExtension;
 use PHPStan\Type\Doctrine\ObjectMetadataResolver;
 use Throwable;
-use function array_key_exists;
 use function in_array;
 
 class PropertiesExtension implements ReadWritePropertiesExtension
@@ -47,7 +46,7 @@ public function isAlwaysWritten(PropertyReflection $property, string $propertyNa
 
 		if (isset($metadata->fieldMappings[$propertyName])) {
 			$mapping = $metadata->fieldMappings[$propertyName];
-			if (array_key_exists('generated', $mapping) && $mapping['generated'] !== ClassMetadata::GENERATED_NEVER) {
+			if (isset($mapping['generated']) && $mapping['generated'] !== ClassMetadata::GENERATED_NEVER) {
 				return true;
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,6 @@`
`7`	`7`	`use PHPStan\Rules\Properties\ReadWritePropertiesExtension;`
`8`	`8`	`use PHPStan\Type\Doctrine\ObjectMetadataResolver;`
`9`	`9`	`use Throwable;`
`10`		`-use function array_key_exists;`
`11`	`10`	`use function in_array;`
`12`	`11`
`13`	`12`	`class PropertiesExtension implements ReadWritePropertiesExtension`
`@@ -47,7 +46,7 @@ public function isAlwaysWritten(PropertyReflection $property, string $propertyNa`
`47`	`46`
`48`	`47`	`if (isset($metadata->fieldMappings[$propertyName])) {`
`49`	`48`	`$mapping = $metadata->fieldMappings[$propertyName];`
`50`		`- if (array_key_exists('generated', $mapping) && $mapping['generated'] !== ClassMetadata::GENERATED_NEVER) {`
	`49`	`+ if (isset($mapping['generated']) && $mapping['generated'] !== ClassMetadata::GENERATED_NEVER) {`
`51`	`50`	`return true;`
`52`	`51`	`}`
`53`	`52`	`}`