Fix canChangeTypeAfterAssignment

Author: ondrejmirtes

src/Reflection/Php/PhpPropertyReflection.php

@@ -116,6 +116,22 @@ public function getWritableType(): Type
 
 	public function canChangeTypeAfterAssignment(): bool
 	{
+		if ($this->isStatic()) {
+			return true;
+		}
+
+		if ($this->isVirtual()->yes()) {
+			return false;
+		}
+
+		if ($this->hasHook('get')) {
+			return false;
+		}
+
+		if ($this->hasHook('set')) {
+			return false;
+		}
+
 		return true;
 	}
 

tests/PHPStan/Analyser/nsrt/property-hooks.php

@@ -311,3 +311,49 @@ public function __construct(
 	}
 
 }
+
+class CanChangeTypeAfterAssignment
+{
+
+	public int $i;
+
+	public function doFoo(): void
+	{
+		assertType('int', $this->i);
+		$this->i = 1;
+		assertType('1', $this->i);
+	}
+
+	public int $virtual {
+		get {
+			return 1;
+		}
+		set {
+			$this->i = 1;
+		}
+	}
+
+	public function doFoo2(): void
+	{
+		assertType('int', $this->virtual);
+		$this->virtual = 1;
+		assertType('int', $this->virtual);
+	}
+
+	public int $backedWithHook {
+		get {
+			return $this->backedWithHook + 100;
+		}
+		set {
+			$this->backedWithHook = $this->backedWithHook - 200;
+		}
+	}
+
+	public function doFoo3(): void
+	{
+		assertType('int', $this->backedWithHook);
+		$this->backedWithHook = 1;
+		assertType('int', $this->backedWithHook);
+	}
+
+}