Invoke PropertyAssignNode in short set property hook

Author: ondrejmirtes

src/Analyser/NodeScopeResolver.php

@@ -4698,6 +4698,7 @@ private function processPropertyHooks(
 
 			if ($hook->body instanceof Expr) {
 				$this->processExprNode($stmt, $hook->body, $hookScope, $nodeCallback, ExpressionContext::createTopLevel());
+				$nodeCallback(new PropertyAssignNode(new PropertyFetch(new Variable('this'), $propertyName, $hook->body->getAttributes()), $hook->body, false), $hookScope);
 			} elseif (is_array($hook->body)) {
 				$this->processStmtNodes($stmt, $hook->body, $hookScope, $nodeCallback, StatementContext::createTopLevel());
 			}

tests/PHPStan/Rules/Properties/TypesAssignedToPropertiesRuleTest.php

@@ -688,4 +688,38 @@ public function testBug12131(): void
 		]);
 	}
 
+	public function testShortBodySetHook(): void
+	{
+		if (PHP_VERSION_ID < 80400) {
+			$this->markTestSkipped('Test requires PHP 8.4.');
+		}
+
+		$this->checkExplicitMixed = true;
+		$this->analyse([__DIR__ . '/data/short-set-property-hook-assign.php'], [
+			[
+				'Property ShortSetPropertyHookAssign\Foo::$i (int) does not accept string.',
+				9,
+			],
+			[
+				'Property ShortSetPropertyHookAssign\Foo::$s (non-empty-string) does not accept \'\'.',
+				18,
+			],
+			[
+				'Property ShortSetPropertyHookAssign\GenericFoo<T of ShortSetPropertyHookAssign\Foo>::$a (T of ShortSetPropertyHookAssign\Foo) does not accept ShortSetPropertyHookAssign\Foo.',
+				36,
+				'Type ShortSetPropertyHookAssign\Foo is not always the same as T. It breaks the contract for some argument types, typically subtypes.',
+			],
+			[
+				'Property ShortSetPropertyHookAssign\GenericFoo<T of ShortSetPropertyHookAssign\Foo>::$b (T of ShortSetPropertyHookAssign\Foo) does not accept ShortSetPropertyHookAssign\Foo.',
+				50,
+				'Type ShortSetPropertyHookAssign\Foo is not always the same as T. It breaks the contract for some argument types, typically subtypes.',
+			],
+			[
+				'Property ShortSetPropertyHookAssign\GenericFoo<T of ShortSetPropertyHookAssign\Foo>::$c (T of ShortSetPropertyHookAssign\Foo) does not accept ShortSetPropertyHookAssign\Foo.',
+				59,
+				'Type ShortSetPropertyHookAssign\Foo is not always the same as T. It breaks the contract for some argument types, typically subtypes.',
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Properties/data/short-set-property-hook-assign.php

@@ -0,0 +1,69 @@
+<?php // lint >= 8.4
+
+namespace ShortSetPropertyHookAssign;
+
+class Foo
+{
+
+	public int $i {
+		set => 'foo';
+	}
+
+	public int $i2 {
+		set => 1;
+	}
+
+	/** @var non-empty-string */
+	public string $s {
+		set => '';
+	}
+
+	/** @var non-empty-string */
+	public string $s2 {
+		set => 'foo';
+	}
+
+}
+
+/**
+ * @template T of Foo
+ */
+class GenericFoo
+{
+
+	/** @var T */
+	public Foo $a {
+		set => new Foo();
+	}
+
+	/** @var T */
+	public Foo $a2 {
+		set => $this->a2;
+	}
+
+	/**
+	 * @param T $c
+	 */
+	public function __construct(
+		/** @var T */
+		public Foo $b {
+			set => new Foo();
+		},
+
+		/** @var T */
+		public Foo $b2 {
+			set => $this->b2;
+		},
+
+		public Foo $c {
+			set => new Foo();
+		},
+
+		public Foo $c2 {
+			set => $this->c2;
+		}
+	)
+	{
+	}
+
+}