Detect hooked properties outside of constructor

Author: ondrejmirtes

Makefile

@@ -87,6 +87,7 @@ lint:
 		--exclude tests/PHPStan/Rules/Properties/data/non-abstract-hooked-properties-in-class.php \
 		--exclude tests/PHPStan/Rules/Properties/data/hooked-properties-in-class.php \
 		--exclude tests/PHPStan/Rules/Properties/data/hooked-properties-without-bodies-in-class.php \
+		--exclude tests/PHPStan/Rules/Classes/data/invalid-hooked-properties.php \
 		src tests
 
 cs:

src/Rules/Classes/InvalidPromotedPropertiesRule.php

@@ -31,7 +31,12 @@ public function processNode(Node $node, Scope $scope): array
 		$hasPromotedProperties = false;
 
 		foreach ($node->getParams() as $param) {
-			if ($param->flags === 0) {
+			if ($param->flags !== 0) {
+				$hasPromotedProperties = true;
+				break;
+			}
+
+			if ($param->hooks === []) {
 				continue;
 			}
 

tests/PHPStan/Rules/Classes/InvalidPromotedPropertiesRuleTest.php

@@ -104,4 +104,19 @@ public function testBug9577(): void
 		$this->analyse([__DIR__ . '/data/bug-9577.php'], []);
 	}
 
+	public function testHooks(): void
+	{
+		if (PHP_VERSION_ID < 80100) {
+			$this->markTestSkipped('Test requires PHP 8.4.');
+		}
+
+		$this->phpVersion = 80100;
+		$this->analyse([__DIR__ . '/data/invalid-hooked-properties.php'], [
+			[
+				'Promoted properties can be in constructor only.',
+				9,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Classes/data/invalid-hooked-properties.php

@@ -0,0 +1,21 @@
+<?php
+
+namespace InvalidHookedProperties;
+
+use DateTimeImmutable;
+
+class HelloWorld
+{
+	public function sayHello(DateTimeImmutable $date { get; }): void
+	{
+
+	}
+}
+
+class ValidPromotedProperty
+{
+	public function __construct(DateTimeImmutable $date { get {} })
+	{
+
+	}
+}