Treat ConstantArrayType as covariant in its keys and values

This should be safe because it is copy-on-write

Author: jiripudil

src/Type/Constant/ConstantArrayType.php

@@ -1368,7 +1368,7 @@ public function inferTemplateTypes(Type $receivedType): TemplateTypeMap
 
 	public function getReferencedTemplateTypes(TemplateTypeVariance $positionVariance): array
 	{
-		$variance = $positionVariance->compose(TemplateTypeVariance::createInvariant());
+		$variance = $positionVariance->compose(TemplateTypeVariance::createCovariant());
 		$references = [];
 
 		foreach ($this->keyTypes as $type) {

tests/PHPStan/Rules/Generics/MethodSignatureVarianceRuleTest.php

@@ -219,4 +219,9 @@ public function testBug8880(): void
 		]);
 	}
 
+	public function testBug9161(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-9161.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Generics/data/bug-9161.php

@@ -0,0 +1,39 @@
+<?php declare(strict_types = 1); // lint >= 8.0
+
+namespace Bug9161;
+
+/**
+ * @template-covariant TKey of int|string
+ * @template-covariant TValue
+ */
+final class Map
+{
+	/**
+	 * @param array<TKey, TValue> $items
+	 */
+	public function __construct(
+		private array $items = [],
+	) {
+	}
+
+	/**
+	 * @return array<TKey, TValue>
+	 */
+	public function toArray(): array
+	{
+		return $this->items;
+	}
+
+	/**
+	 * @return list<array{0: TKey, 1: TValue}>
+	 */
+	public function toPairs(): array
+	{
+		$pairs = [];
+		foreach ($this->items as $key => $value) {
+			$pairs[] = [$key, $value];
+		}
+
+		return $pairs;
+	}
+}