clear out NULL height/width (for polar)

cpsievert · cpsievert · commit 9400d1b86bab · 2016-09-12T18:54:09.000-05:00
diff --git a/R/plotly_build.R b/R/plotly_build.R
@@ -249,6 +249,10 @@ plotly_build.plotly <- function(p) {
     }
   }
 
+  # polar charts don't like null width/height keys 
+  if (is.null(p$x$layout[["height"]])) p$x$layout[["height"]] <- NULL
+  if (is.null(p$x$layout[["width"]])) p$x$layout[["width"]] <- NULL
+  
   # ensure we get the order of categories correct
   # (plotly.js uses the order in which categories appear by default)
   p <- populate_categorical_axes(p)

Original file line number	Diff line number	Diff line change
`@@ -249,6 +249,10 @@ plotly_build.plotly <- function(p) {`
`249`	`249`	`}`
`250`	`250`	`}`
`251`	`251`
	`252`	`+ # polar charts don't like null width/height keys`
	`253`	`+ if (is.null(p$x$layout[["height"]])) p$x$layout[["height"]] <- NULL`
	`254`	`+ if (is.null(p$x$layout[["width"]])) p$x$layout[["width"]] <- NULL`
	`255`	`+`
`252`	`256`	`# ensure we get the order of categories correct`
`253`	`257`	`# (plotly.js uses the order in which categories appear by default)`
`254`	`258`	`p <- populate_categorical_axes(p)`