restrict to atomic vectors

Author: cpsievert

R/plotly_build.R

@@ -103,7 +103,7 @@ plotly_build.plotly <- function(p) {
     # I'm looking at you scattergeo...
     tr <- trace[names(trace) %in% c(npscales(), special_attrs(trace), dataArrayAttrs, "text")]
     # TODO: does it make sense to "train" matrices/2D-tables (e.g. z)?
-    tr <- tr[vapply(tr, function(x) is.null(dim(x)), logical(1))]
+    tr <- tr[vapply(tr, function(x) is.null(dim(x)) && is.atomic(x), logical(1))]
     builtData <- tibble::as_tibble(tr)
 
     # avoid clobbering I() (i.e., variables that shouldn't be scaled)

tests/testthat/test-plotly.R

@@ -161,3 +161,27 @@ test_that("Discrete variable mapped to x creates horizontal bar chart", {
   expect_equal(unique(o), "h")
   expect_equal(unique(types), "histogram")
 })
+
+
+
+test_that("Complex example works", {
+  # note how median (the variable) doesn't exist in the second layer 
+  p <- txhousing %>%
+    plot_ly(x = ~date, y = ~median) %>%
+    group_by(city) %>%
+    add_lines(alpha = 0.2, name = "Texan Cities", hoverinfo = "none") %>%
+    group_by(date) %>% 
+    summarise(
+      q1 = quantile(median, 0.25, na.rm = TRUE),
+      m = median(median, na.rm = TRUE),
+      q3 = quantile(median, 0.75, na.rm = TRUE)
+    ) %>%
+    add_lines(y = ~m, color = I("red"), name = "median") %>%
+    add_ribbons(ymin = ~q1, ymax = ~q3, color = I("red"), name = "IQR")
+  
+  l <- expect_traces(p, 3, "time-series-summary")
+})
+
+
+
+