accumulate mode bar buttons

Author: cpsievert

R/layout.R

@@ -60,10 +60,24 @@ rangeslider <- function(p, ...) {
 #' @author Carson Sievert
 #' @export
 #' @examples \dontrun{
-#' config(plot_ly(), displaylogo = FALSE, modeBarButtonsToRemove = list('sendDataToCloud'))
+#' config(plot_ly(), displaylogo = FALSE)
 #' }
 
 config <- function(p, ...) {
-  p$x$config <- modify_list(p$x$config, list(...))
+  attrs <- list(...)
+  # accumulate these attributes
+  p$x$config[["modeBarButtonsToRemove"]] <- c(
+    p$x$config[["modeBarButtonsToRemove"]] %||% 'sendDataToCloud',
+    attrs[["modeBarButtonsToRemove"]]
+  )
+  if (length(p$x$config[["modeBarButtonsToRemove"]])) {
+    p$x$config[["modeBarButtonsToRemove"]] <- list(p$x$config[["modeBarButtonsToRemove"]])
+  }
+  p$x$config[["modeBarButtonsToAdd"]] <- c(
+    list(sharingButton()),
+    attrs[["modeBarButtonsToAdd"]]
+  )
+  attrs <- attrs[grepl("modeBarButtonsTo", names(attrs))]
+  p$x$config <- modify_list(p$x$config, attrs)
   p
 }

R/plotly_build.R

@@ -323,15 +323,9 @@ plotly_build.plotly <- function(p) {
   p <- verify_hovermode(p)
   # try to convert to webgl if toWebGl was used
   p <- verify_webgl(p)
-  
-  
-  # TODO: avoid overwritting user specified args
-  p <- config(p,
-              modeBarButtonsToRemove = I("sendDataToCloud"),
-              modeBarButtonsToAdd = list(sharingButton())
-  )
+  # populate R's non-default config
+  p <- config(p)
   p$x$base_url <- get_domain()
-  
   p
 }