don't namespace under-the-hood

Author: cpsievert

R/plotly.R

@@ -78,8 +78,7 @@
 plot_ly <- function(data = data.frame(), ..., type = NULL, 
                     color, colors = NULL, alpha = 1, symbol, symbols = NULL, 
                     size, sizes = c(10, 100), linetype, linetypes = NULL,
-                    width = NULL, height = NULL, source = "A", 
-                    session = shiny::getDefaultReactiveDomain()) {
+                    width = NULL, height = NULL, source = "A") {
   if (!is.data.frame(data)) {
     stop("First argument, `data`, must be a data frame.", call. = FALSE)
   }
@@ -120,10 +119,7 @@ plot_ly <- function(data = data.frame(), ..., type = NULL,
   id <- new_id()
   # avoid weird naming clashes
   plotlyVisDat <- data
-  # automatically namespace source
-  if (!is.null(session)) {
-    source <- session$ns(source)
-  }
+  
   p <- list(
     visdat = setNames(list(function() plotlyVisDat), id),
     cur_data = id,

R/shiny.R

@@ -54,7 +54,7 @@ event_data <- function(event = c("plotly_hover", "plotly_click", "plotly_selecte
     stop("No reactive domain detected. This function can only be called \n",
          "from within a reactive shiny context.")
   }
-  src <- sprintf(".clientValue-%s-%s", event[1], session$ns(source))
+  src <- sprintf(".clientValue-%s-%s", event[1], source)
   val <- session$rootScope()$input[[src]]
   if (is.null(val)) val else jsonlite::fromJSON(val)
 }

inst/examples/plotlyShinyModules/app.R

@@ -7,23 +7,31 @@ reusableUI <- function(id = NULL) {
   fluidRow(
     column(4, plotlyOutput(ns("p1"))),
     column(4, plotlyOutput(ns("p2"))),
-    column(4, verbatimTextOutput(ns("ev")))
+    column(4, verbatimTextOutput(ns("ev1"))),
+    column(4, verbatimTextOutput(ns("ev2")))
   )
 }
 
-viz <- function(input, output, session) {
+viz <- function(input, output, scope, src) {
+  
+  # if you want, you can define multiple sources here
+  src2 <- paste0(src, "2")
+  
   output$p1 <- renderPlotly({
     plot_ly(mtcars, x = ~mpg, y = ~disp, 
-            key = row.names(mtcars), session = session)
+            key = row.names(mtcars), source = src)
   })
   output$p2 <- renderPlotly({
     plot_ly(mtcars, x = ~mpg, y = ~disp, 
-            key = row.names(mtcars), session = session)
+            key = row.names(mtcars), source = src2)
   })
-  output$ev <- renderPrint({
-    d <- event_data("plotly_hover", session = session)
-    if (is.null(d)) print(paste("Module", session$ns(NULL))) else d
+  output$ev1 <- renderPrint({
+    event_data("plotly_hover", source = src)
   })
+  output$ev2 <- renderPrint({
+    event_data("plotly_hover", source = src2)
+  })
+  
 }
 
 ui <- fluidPage(
@@ -32,8 +40,9 @@ ui <- fluidPage(
 )
 
 server <- function(input, output, session) {
-  callModule(viz, "one", session = session)
-  callModule(viz, "two", session = session)
+  # use the src argument to namespace plotly events
+  callModule(viz, "one", src = "A")
+  callModule(viz, "two", src = "B")
 }
 
 shinyApp(ui, server)