Skip to content

Commit 082fdfd

Browse files
committed
few last comments
1 parent 6080d80 commit 082fdfd

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

plotly/figure_factory/_bullet.py

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -128,17 +128,13 @@ def _bullet(df, markers, measures, ranges, subtitles, titles, orientation,
128128
markers = go.Scatter(
129129
x=x,
130130
y=y,
131-
marker=scatter_options['marker'],
132131
name='markers',
133132
hoverinfo='x' if orientation == 'h' else 'y',
134133
xaxis='x{}'.format(row + 1),
135-
yaxis='y{}'.format(row + 1)
134+
yaxis='y{}'.format(row + 1),
135+
**scatter_options
136136
)
137137

138-
for k in scatter_options:
139-
if k != 'marker':
140-
markers[k] = scatter_options[k]
141-
142138
fig['data'].append(markers)
143139

144140
# titles and subtitles
@@ -188,9 +184,6 @@ def create_bullet(data, markers=None, measures=None, ranges=None,
188184
of each subplot chart.
189185
:param (bool) orientation: if 'h', the bars are placed horizontally as
190186
rows. If 'v' the bars are placed vertically in the chart.
191-
:param (int) marker_size: sets the size of the markers in the chart.
192-
:param (str | int) marker_symbol: the symbol of the markers in the chart.
193-
Default='diamond-tall'
194187
:param (list) range_colors: a list of two colors between which all
195188
the rectangles for the range are drawn. These rectangles are meant to
196189
be qualitative indicators against which the marker and measure bars

0 commit comments

Comments
 (0)