Now subscripting errors triggered on types throwing TypeError

Before the subscripting error was only thrown for NoneType objects, but
because stuff like `"hello"["hi"]` and `1["hey"]` also are invalid, and
these also throw TypeError, then these throw the subscripting error
message too. HOWEVER, this error is casted to ValueError on property
assignment and PlotlyKeyError on property read, to keep consistency
among the exception types.

Author: nicholas-esterer

packages/python/plotly/plotly/basedatatypes.py

@@ -137,7 +137,7 @@ def _check_path_in_prop_tree(obj, path, error_cast=None):
             obj = obj[p]
         except (ValueError, KeyError, IndexError, TypeError) as e:
             arg = e.args[0]
-            if obj is None:
+            if issubclass(e.__class__, TypeError):
                 # If obj doesn't support subscripting, state that and show the
                 # (valid) property that gives the object that doesn't support
                 # subscripting.

packages/python/plotly/plotly/tests/test_core/test_errors/test_dict_path_errors.py

@@ -361,3 +361,61 @@ def test_describes_subscripting_error(some_fig):
             and (e_substr == e_correct_substr)
         )
     assert raised
+
+
+def test_described_subscript_error_on_type_error(some_fig):
+    # The above tests for subscripting errors did not test for when we attempt
+    # to subscript an object that is not None, such as a string or a number.
+    # These do that.
+    raised = False
+    try:
+        # Trying to address with a key an object that doesn't support it (as we
+        # do below) reports an error listing what are valid assignments to the
+        # object, like when we try and assign a number to something that expects as string.
+        some_fig["layout_template_layout_plot_bgcolor"] = 1
+    except ValueError as e:
+        raised = True
+        e_correct_substr = error_substr(
+            e.args[0],
+            """
+    Invalid value of type 'builtins.int' received for the 'plot_bgcolor' property of layout
+        Received value: 1
+""",
+        )
+        e_correct_substr += """
+
+Property does not support subscripting:
+template_layout_plot_bgcolor_x
+                ~~~~~~~~~~~~"""
+    assert raised
+    raised = False
+    try:
+        some_fig.update_layout(template_layout_plot_bgcolor_x=1)
+    except ValueError as e:
+        raised = True
+        print(e.args[0])
+        e_substr = error_substr(
+            e.args[0],
+            """string indices must be integers
+
+Invalid value received for the 'plot_bgcolor' property of layout
+""",
+        )
+        assert e_substr == e_correct_substr
+    assert raised
+
+
+def test_subscript_error_exception_types(some_fig):
+    # Assert that these raise the expected error types
+    # when width is None
+    with pytest.raises(ValueError):
+        some_fig.update_layout(width_yo=100)
+    with pytest.raises(KeyError):
+        yo = some_fig["layout_width_yo"]
+
+    some_fig.update_layout(width=100)
+    # when width is specified
+    with pytest.raises(ValueError):
+        some_fig.update_layout(width_yo=100)
+    with pytest.raises(KeyError):
+        yo = some_fig["layout_width_yo"]