Assert that errors are raised

Author: nicholas-esterer

packages/python/plotly/plotly/tests/test_core/test_errors/test_dict_path_errors.py

@@ -20,9 +20,11 @@ def some_fig():
 
 def test_raises_on_bad_index(some_fig):
     # Check indexing errors can be detected when path used as key to go.Figure
+    raised = False
     try:
         x0 = some_fig["layout.shapes[2].x0"]
     except IndexError as e:
+        raised = True
         assert (
             e.args[0].find(
                 """Bad property path:
@@ -31,15 +33,18 @@ def test_raises_on_bad_index(some_fig):
             )
             >= 0
         )
+    assert raised
 
 
 def test_raises_on_bad_dot_property(some_fig):
 
     # Check . property lookup errors can be detected when path used as key to
     # go.Figure
+    raised = False
     try:
         x2000 = some_fig["layout.shapes[1].x2000"]
     except ValueError as e:
+        raised = True
         assert (
             e.args[0].find(
                 """Bad property path:
@@ -48,14 +53,17 @@ def test_raises_on_bad_dot_property(some_fig):
             )
             >= 0
         )
+    assert raised
 
 
 def test_raises_on_bad_ancestor_dot_property(some_fig):
 
     # Check . property lookup errors but not on the last part of the path
+    raised = False
     try:
         x2000 = some_fig["layout.shapa[1].x2000"]
     except ValueError as e:
+        raised = True
         assert (
             e.args[0].find(
                 """Bad property path:
@@ -64,16 +72,19 @@ def test_raises_on_bad_ancestor_dot_property(some_fig):
             )
             >= 0
         )
+    assert raised
 
 
 def test_raises_on_bad_indexed_underscore_property(some_fig):
 
     # finds bad part when using the path as a key to figure and throws the error
     # for the last good property it found in the path
+    raised = False
     try:
         # get the error without using a path-like key, we compare with this error
         some_fig.data[0].line["colr"] = "blue"
     except ValueError as e_correct:
+        raised = True
         # remove "Bad property path:
         e_correct_substr = error_substr(
             e_correct.args[0],
@@ -85,9 +96,13 @@ def test_raises_on_bad_indexed_underscore_property(some_fig):
     # if the string starts with "Bad property path:" then this test cannot work
     # this way.
     assert len(e_correct_substr) > 0
+    assert raised
+
+    raised = False
     try:
         some_fig["data[0].line_colr"] = "blue"
     except ValueError as e:
+        raised = True
         e_substr = error_substr(
             e.args[0],
             """
@@ -106,24 +121,31 @@ def test_raises_on_bad_indexed_underscore_property(some_fig):
             )
             and (e_substr == e_correct_substr)
         )
+    assert raised
 
+    raised = False
     try:
         # get the error without using a path-like key
         some_fig.add_trace(go.Scatter(x=[1, 2], y=[3, 4], line=dict(colr="blue")))
     except ValueError as e_correct:
+        raised = True
         e_correct_substr = error_substr(
             e_correct.args[0],
             """
 Bad property path:
 colr
 ^""",
         )
+    assert raised
+
+    raised = False
     # finds bad part when using the path as a keyword argument to a subclass of
     # BasePlotlyType and throws the error for the last good property found in
     # the path
     try:
         some_fig.add_trace(go.Scatter(x=[1, 2], y=[3, 4], line_colr="blue"))
     except ValueError as e:
+        raised = True
         e_substr = error_substr(
             e.args[0],
             """
@@ -142,24 +164,30 @@ def test_raises_on_bad_indexed_underscore_property(some_fig):
             )
             and (e_substr == e_correct_substr)
         )
+    assert raised
 
+    raised = False
     # finds bad part when using the path as a keyword argument to a subclass of
     # BaseFigure and throws the error for the last good property found in
     # the path
     try:
         fig2 = go.Figure(layout=dict(title=dict(txt="two")))
     except ValueError as e_correct:
+        raised = True
         e_correct_substr = error_substr(
             e_correct.args[0],
             """
 Bad property path:
 txt
 ^""",
         )
+    assert raised
 
+    raised = False
     try:
         fig2 = go.Figure(layout_title_txt="two")
     except TypeError as e:
+        raised = True
         # when the Figure constructor sees the same ValueError above, a
         # TypeError is raised and adds an error message in front of the same
         # ValueError thrown above
@@ -187,22 +215,29 @@ def test_raises_on_bad_indexed_underscore_property(some_fig):
             )
             and (e_substr == e_correct_substr)
         )
+    assert raised
 
+    raised = False
     # this is like the above test for subclasses of BasePlotlyType but makes sure it
     # works when the bad part is not the last part in the path
     try:
         some_fig.update_layout(geo=dict(ltaxis=dict(showgrid=True)))
     except ValueError as e_correct:
+        raised = True
         e_correct_substr = error_substr(
             e_correct.args[0],
             """
 Bad property path:
 ltaxis
 ^""",
         )
+    assert raised
+
+    raised = False
     try:
         some_fig.update_layout(geo_ltaxis_showgrid=True)
     except ValueError as e:
+        raised = True
         e_substr = error_substr(
             e.args[0],
             """
@@ -221,3 +256,4 @@ def test_raises_on_bad_indexed_underscore_property(some_fig):
             )
             and (e_substr == e_correct_substr)
         )
+    assert raised