Fix on_change callback tests

Author: jonmmease

plotly/tests/test_core/test_figure_messages/test_on_change.py

@@ -29,31 +29,31 @@ def setUp(self):
     def test_raise_if_no_figure(self):
         scatt = go.Scatter()
         fn = MagicMock()
-        scatt.on_change(fn, False, 'x')
+        scatt.on_change(fn, 'x')
 
     @raises(ValueError)
     def test_raise_on_frame_hierarchy(self):
         fn = MagicMock()
-        self.figure.frames[0].layout.xaxis.on_change(fn, False, 'range')
+        self.figure.frames[0].layout.xaxis.on_change(fn, 'range')
 
     @raises(ValueError)
     def test_validate_property_path_nested(self):
         fn = MagicMock()
-        self.figure.layout.xaxis.on_change(fn, False, 'bogus')
+        self.figure.layout.xaxis.on_change(fn, 'bogus')
 
     @raises(ValueError)
     def test_validate_property_path_nested(self):
         fn = MagicMock()
-        self.figure.layout.on_change(fn, False, 'xaxis.titlefont.bogus')
+        self.figure.layout.on_change(fn, 'xaxis.titlefont.bogus')
 
     # Python triggered changes
     # ------------------------
     def test_single_prop_callback_on_assignment(self):
         # Install callbacks on 'x', and 'y' property of first trace
         fn_x = MagicMock()
         fn_y = MagicMock()
-        self.figure.data[0].on_change(fn_x, False, 'x')
-        self.figure.data[0].on_change(fn_y, False, 'y')
+        self.figure.data[0].on_change(fn_x, 'x')
+        self.figure.data[0].on_change(fn_y, 'y')
 
         # Setting x and y on second trace does not trigger callback
         self.figure.data[1].x = [1, 2, 3]
@@ -74,7 +74,7 @@ def test_single_prop_callback_on_assignment(self):
     def test_multi_prop_callback_on_assignment_trace(self):
         # Register callback if either 'x' or 'y' changes on first trace
         fn = MagicMock()
-        self.figure.data[0].on_change(fn, False, 'x', 'y')
+        self.figure.data[0].on_change(fn, 'x', 'y')
 
         # Perform assignment on one of the properties
         self.figure.data[0].x = [11, 22, 33]
@@ -89,7 +89,7 @@ def test_multi_prop_callback_on_assignment_layout(self):
 
         # Register callback if either axis range is changed. Both tuple and
         # dot syntax are supported for nested properties
-        self.figure.layout.on_change(fn_range, False,
+        self.figure.layout.on_change(fn_range,
                                      ('xaxis', 'range'),
                                      'yaxis.range')
 
@@ -102,18 +102,17 @@ def test_multi_prop_callback_on_assignment_layout_nested(self):
         fn_layout = MagicMock()
 
         # Register callback on change to family property under titlefont
-        self.figure.layout.xaxis.titlefont.on_change(fn_titlefont, False,
+        self.figure.layout.xaxis.titlefont.on_change(fn_titlefont,
                                                      'family')
 
         # Register callback on the range and titlefont.family properties
         # under xaxis
         self.figure.layout.xaxis.on_change(fn_xaxis,
-                                           False, 
                                            'range',
                                            'titlefont.family')
 
         # Register callback on xaxis object itself
-        self.figure.layout.on_change(fn_layout, False, 'xaxis')
+        self.figure.layout.on_change(fn_layout, 'xaxis')
 
         # Assign a new xaxis range and titlefont.family
         self.figure.layout.xaxis.titlefont.family = 'courier'
@@ -145,10 +144,10 @@ def test_prop_callback_nested_arrays(self):
         fn_layout = MagicMock()
 
         self.figure.layout.updatemenus[2].buttons[1].on_change(
-            fn_button, False, 'method')
+            fn_button, 'method')
 
         self.figure.layout.on_change(
-            fn_layout, False, 'updatemenus[2].buttons[1].method')
+            fn_layout, 'updatemenus[2].buttons[1].method')
 
         # Update button method
         self.figure.layout.updatemenus[2].buttons[1].method = 'restyle'
@@ -162,7 +161,6 @@ def test_prop_callback_nested_arrays(self):
     def test_callback_on_update(self):
         fn_range = MagicMock()
         self.figure.layout.on_change(fn_range,
-                                     False, 
                                      'xaxis.range',
                                      'yaxis.range')
 
@@ -174,7 +172,6 @@ def test_callback_on_update(self):
     def test_callback_on_update_single_call(self):
         fn_range = MagicMock()
         self.figure.layout.on_change(fn_range,
-                                     False,
                                      'xaxis.range',
                                      'yaxis.range',
                                      'width')
@@ -193,7 +190,6 @@ def test_callback_on_update_single_call(self):
     def test_callback_on_batch_update(self):
         fn_range = MagicMock()
         self.figure.layout.on_change(fn_range,
-                                     False,
                                      'xaxis.range',
                                      'yaxis.range',
                                      'width')
@@ -212,7 +208,6 @@ def test_callback_on_batch_update(self):
     def test_callback_on_batch_animate(self):
         fn_range = MagicMock()
         self.figure.layout.on_change(fn_range,
-                                     False,
                                      'xaxis.range',
                                      'yaxis.range',
                                      'width')
@@ -231,7 +226,6 @@ def test_callback_on_batch_animate(self):
     def test_callback_on_plotly_relayout(self):
         fn_range = MagicMock()
         self.figure.layout.on_change(fn_range,
-                                     False,
                                      'xaxis.range',
                                      'yaxis.range',
                                      'width')
@@ -248,7 +242,7 @@ def test_callback_on_plotly_relayout(self):
     def test_callback_on_plotly_restyle(self):
         # Register callback if either 'x' or 'y' changes on first trace
         fn = MagicMock()
-        self.figure.data[0].on_change(fn, False, 'x', 'y')
+        self.figure.data[0].on_change(fn, 'x', 'y')
 
         # Perform assignment on one of pthe properties
         self.figure.plotly_restyle({'x': [[11, 22, 33],
@@ -263,7 +257,6 @@ def test_callback_on_plotly_restyle(self):
     def test_callback_on_plotly_update(self):
         fn_range = MagicMock()
         self.figure.layout.on_change(fn_range,
-                                     False,
                                      'xaxis.range',
                                      'yaxis.range',
                                      'width')