Make publishing optional.

Author: rkistner

.github/actions/upload/action.yml

@@ -15,10 +15,9 @@ runs:
   using: "composite"
   steps:
     - name: Upload binary
-      uses: svenstaro/upload-release-action@v2
-      with:
-        repo_token: ${{ inputs.repo-token }}
-        overwrite: true
-        file: ${{ inputs.file-name }}
-        asset_name: ${{ inputs.file-name }}
-        tag: ${{ inputs.tag }}
+      shell: bash
+      env:
+        GH_TOKEN: ${{ github.token }}
+        GH_REPO: ${{ github.repository }}
+      run: |
+        gh release upload "${{ inputs.tag }}" "${{ inputs.file-name }}"

.github/workflows/linux.yml

@@ -1,6 +1,5 @@
 on:
   push:
-  workflow_dispatch:
 name: "linux"
 jobs:
   build_x86_64:
@@ -20,14 +19,6 @@ jobs:
       - name: Build binaries
         run: ./tool/build_linux.sh x64
 
-      - name: Upload binary
-        if: github.event_name == 'workflow_dispatch'
-        uses: ./.github/actions/upload
-        with:
-          repo-token: ${{ secrets.GITHUB_TOKEN }}
-          file-name: libpowersync_x64.so
-          tag: ${{ github.ref_name }}
-
   build_aarch64:
     name: Building Linux aarch64
     runs-on: ubuntu-arm64
@@ -44,11 +35,3 @@ jobs:
 
       - name: Build binaries
         run: ./tool/build_linux.sh aarch64
-
-      - name: Upload binary
-        if: github.event_name == 'workflow_dispatch'
-        uses: ./.github/actions/upload
-        with:
-          repo-token: ${{ secrets.GITHUB_TOKEN }}
-          file-name: libpowersync_aarch64.so
-          tag: ${{ github.ref_name }}

.github/workflows/release.yml

@@ -1,7 +1,12 @@
 name: release
 on:
   workflow_dispatch:
-  push:
+    inputs:
+      publish:
+        type: boolean
+        required: false
+        default: false
+        description: Set to true to publish artifacts to external targets such as Maven Central
 jobs:
   draft_release:
     if: github.event_name == 'workflow_dispatch'
@@ -57,6 +62,7 @@ jobs:
           cargo install cargo-ndk
 
       - name: Publish for Android
+        if: ${{ inputs.publish }}
         run: |
           cd android
           ./gradlew publish
@@ -123,7 +129,7 @@ jobs:
           components: rust-src
 
       - name: Build binaries
-        run: bash tool/build_linux.sh x64
+        run: ./tool/build_linux.sh x64
 
       - name: Upload binary
         uses: ./.github/actions/upload
@@ -135,7 +141,7 @@ jobs:
   publish_linux_aarch64:
     name: Publish Linux aarch64
     needs: [draft_release]
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-arm64
     steps:
       - uses: actions/checkout@v3
         with:
@@ -148,7 +154,7 @@ jobs:
           components: rust-src
 
       - name: Build binaries
-        run: bash tool/build_linux.sh aarch64
+        run: ./tool/build_linux.sh aarch64
 
       - name: Upload binary
         uses: ./.github/actions/upload
@@ -166,8 +172,14 @@ jobs:
         with:
           submodules: true
 
+      - name: Install Rust Nightly
+        uses: dtolnay/rust-toolchain@stable
+        with:
+          toolchain: nightly-2024-05-18
+          components: rust-src
+
       - name: Build binary
-        run: bash tool/build_windows.sh x64
+        run: ./tool/build_windows.sh x64
 
       - name: Upload binary
         uses: ./.github/actions/upload
@@ -185,8 +197,14 @@ jobs:
         with:
           submodules: true
 
+      - name: Install Rust Nightly
+        uses: dtolnay/rust-toolchain@stable
+        with:
+          toolchain: nightly-2024-05-18
+          components: rust-src
+
       - name: Build binary
-        run: bash tool/build_macos.sh aarch64
+        run: ./tool/build_macos.sh aarch64
 
       - name: Upload binary
         uses: ./.github/actions/upload
@@ -204,8 +222,14 @@ jobs:
         with:
           submodules: true
 
+      - name: Install Rust Nightly
+        uses: dtolnay/rust-toolchain@stable
+        with:
+          toolchain: nightly-2024-05-18
+          components: rust-src
+
       - name: Build binary
-        run: bash tool/build_macos.sh x64
+        run: ./tool/build_macos.sh x64
 
       - name: Upload binary
         uses: ./.github/actions/upload

RELEASING.md

@@ -21,7 +21,7 @@ git push --tags
 Build:
 
 ```
-gh workflow run release --ref v1.2.3
+gh workflow run release --ref v1.2.3 -f publish=true
 ```
 
 The above does the following: