cleanup

Author: stevensJourney

Sources/PowerSync/Kotlin/KotlinPowerSyncDatabaseImpl.swift

@@ -19,8 +19,9 @@ final class KotlinPowerSyncDatabaseImpl: PowerSyncDatabaseProtocol,
     ) {
         self.logger = logger
         self.kotlinDatabase = kotlinDatabase
-        // We currently use the dbFilename to delete the database files when the database is closed
-        // The kotlin PowerSyncdatabase.identifier currently prepends `null` to the dbFilename (for the directory).
+        /// We currently use the dbFilename to delete the database files when the database is closed
+        /// The kotlin PowerSyncDatabase.identifier currently prepends `null` to the dbFilename (for the directory).
+        /// FIXME. Update this once we support database directory configuration.
         self.dbFilename = dbFilename
         currentStatus = KotlinSyncStatus(
             baseStatus: kotlinDatabase.currentStatus

Sources/PowerSyncGRDB/Config/Configuration+PowerSync.swift

@@ -28,7 +28,7 @@ public extension Configuration {
     ) throws {
         // Handles the case on WatchOS where the extension is statically loaded.
         // We need to register the extension before SQLite connections are established.
-        // This should only throw on non-WatchOS platforms if the extension path cannot be resolved. So we catch and ignore the error.
+        // This should only throw on non-WatchOS platforms if the extension path cannot be resolved.
         let extensionPath = try resolvePowerSyncLoadableExtensionPath()
 
         // Register the PowerSync core extension

Tests/PowerSyncGRDBTests/BasicTest.swift

@@ -82,7 +82,7 @@ final class GRDBTests: XCTestCase {
         database = openPowerSyncWithGRDB(
             pool: pool,
             schema: schema,
-            identifier: "test"
+            identifier: "test.sqlite"
         )
 
         try await database.disconnectAndClear()
@@ -100,11 +100,13 @@ final class GRDBTests: XCTestCase {
         // Create users with the PowerSync SDK
         let initialUserName = "Bob"
 
+        print("creating user \(initialUserName)")
         try await database.execute(
             sql: "INSERT INTO users(id, name) VALUES(uuid(), ?)",
             parameters: [initialUserName]
         )
 
+        print("fetching users")
         // Fetch those users
         let initialUserNames = try await database.getAll(
             "SELECT * FROM users"
@@ -114,6 +116,7 @@ final class GRDBTests: XCTestCase {
 
         XCTAssertTrue(initialUserNames.first == initialUserName)
 
+        print("fetching users with GRDB")
         // Now define a GRDB struct for query purposes
         // Query the Users with GRDB, this should have the same result as with PowerSync
         let grdbUserNames = try await pool.read { database in
@@ -122,6 +125,7 @@ final class GRDBTests: XCTestCase {
 
         XCTAssertTrue(grdbUserNames.first?.name == initialUserName)
 
+        print("inserting user with GRDB")
         // Insert a user with GRDB
         try await pool.write { database in
             try User(
@@ -130,6 +134,7 @@ final class GRDBTests: XCTestCase {
             ).insert(database)
         }
 
+        print("fetching users with GRDB after insert")
         let grdbUserNames2 = try await pool.read { database in
             try User.order(User.Columns.name.asc).fetchAll(database)
         }