chore: added validation when min is greater than max

Author: andrepimpao

docs/03-rules_each-value.md

@@ -1,6 +1,6 @@
 ## EachValue
 
-Validates every element of an `array` or object implementing `\Traversable` with a given set of rules.
+Validates every element of an `array`, or object implementing `\Traversable`, with a given set of rules.
 
 ```php
 EachValue(

src/ChainedValidatorInterface.php

@@ -18,6 +18,14 @@ public function choice(
         string $maxMessage = 'The {{ name }} value must have at most {{ max }} choices, {{ numElements }} choices given.'
     ): ChainedValidatorInterface&Validator;
 
+    public function count(
+        ?int $min = null,
+        ?int $max = null,
+        ?string $minMessage = null,
+        ?string $maxMessage = null,
+        ?string $exactMessage = null
+    ): ChainedValidatorInterface&Validator;
+
     public function country(
         string $code = 'alpha-2',
         string $message = 'The {{ name }} value is not a valid {{ code }} country code, {{ value }} given.'

src/Rule/Count.php

@@ -5,12 +5,13 @@
 use ProgrammatorDev\Validator\Exception\CountException;
 use ProgrammatorDev\Validator\Exception\UnexpectedTypeException;
 use ProgrammatorDev\Validator\Exception\UnexpectedValueException;
+use ProgrammatorDev\Validator\Validator;
 
 class Count extends AbstractRule implements RuleInterface
 {
     private string $minMessage = 'The {{ name }} value should contain {{ min }} elements or more, {{ numElements }} elements given.';
     private string $maxMessage = 'The {{ name }} value should contain {{ max }} elements or less, {{ numElements }} elements given.';
-    private string $exactMessage = 'The {{ name }} value should contain exactly {{ numElements }} elements, {{ numElements }} elements given.';
+    private string $exactMessage = 'The {{ name }} value should contain exactly {{ min }} elements, {{ numElements }} elements given.';
 
     public function __construct(
         private readonly ?int $min = null,
@@ -31,6 +32,14 @@ public function assert(mixed $value, ?string $name = null): void
             throw new UnexpectedValueException('At least one of the options "min" or "max" must be given.');
         }
 
+        if (
+            $this->min !== null
+            && $this->max !== null
+            && !Validator::greaterThanOrEqual($this->min)->validate($this->max)
+        ) {
+            throw new UnexpectedValueException('Maximum value must be greater than or equal to minimum value.');
+        }
+
         if (!\is_countable($value)) {
             throw new UnexpectedTypeException('array|\Countable', get_debug_type($value));
         }

src/Rule/Range.php

@@ -28,9 +28,7 @@ public function assert(mixed $value, ?string $name = null): void
         }
 
         if (!Validator::greaterThan($this->min)->validate($this->max)) {
-            throw new UnexpectedValueException(
-                'Maximum value must be greater than minimum value.'
-            );
+            throw new UnexpectedValueException('Maximum value must be greater than minimum value.');
         }
 
         if (!Validator::greaterThanOrEqual($this->min)->lessThanOrEqual($this->max)->validate($value)) {

src/StaticValidatorInterface.php

@@ -17,6 +17,14 @@ public static function choice(
         string $maxMessage = 'The {{ name }} value must have at most {{ max }} choices, {{ numElements }} choices given.'
     ): ChainedValidatorInterface&Validator;
 
+    public static function count(
+        ?int $min = null,
+        ?int $max = null,
+        ?string $minMessage = null,
+        ?string $maxMessage = null,
+        ?string $exactMessage = null
+    ): ChainedValidatorInterface&Validator;
+
     public static function country(
         string $code = 'alpha-2',
         string $message = 'The {{ name }} value is not a valid {{ code }} country code, {{ value }} given.'

tests/CountTest.php

@@ -20,9 +20,11 @@ public static function provideRuleUnexpectedValueData(): \Generator
     {
         $missingOptionsMessage = '/At least one of the options "min" or "max" must be given./';
         $invalidTypeMessage = '/Expected value of type "array|\Countable", "(.*)" given./';
+        $constraintMessage = '/Maximum value must be greater than or equal to minimum value./';
 
         yield 'missing options' => [new Count(), [1, 2, 3], $missingOptionsMessage];
         yield 'invalid type value' => [new Count(min: 5, max: 10), 1, $invalidTypeMessage];
+        yield 'min greater than max constraint' => [new Count(min: 10, max: 5), 1, $constraintMessage];
     }
 
     public static function provideRuleFailureConditionData(): \Generator