Skip to content

Commit 2b566f9

Browse files
carlosthe19916carlosthe19916
authored
[ISSUE-32] Start verifying CDR notes to pass tests (#33)
* Fix issue-30 * add valid xml for onerosa * Fix tests * Add license * Remove constrains * Remove comment
1 parent d011619 commit 2b566f9

File tree

11 files changed

+77
-78
lines changed

11 files changed

+77
-78
lines changed

‎src/test/java/io/github/project/openubl/xmlbuilderlib/integrationtest/AbstractUBLTest.java‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ public abstract class AbstractUBLTest {
7777
protected TimeZone timeZone;
7878
protected SystemClock systemClock;
7979

80-
protected String PROVIDER_WITHOUT_ADDRESS_NOTE = "3030 - El XML no contiene el tag o no existe información del código de local anexo del emisor";
80+
protected String DOCUMENT_WITHOUT_2007_LEGEND = "4264 - El XML no contiene el codigo de leyenda 2007 para el tipo de operación IVAP";
8181

8282
public AbstractUBLTest() throws Exception {
8383
xPath = XPathFactory.newInstance().newXPath();
@@ -151,8 +151,7 @@ private void sendFileToSunat(Document document, String xmlWithoutSignature, Stri
151151
List<String> notesToCheck = billServiceModel.getNotes().stream().filter(f -> allowedNotesList.stream().noneMatch(f::startsWith)).collect(Collectors.toList());
152152
notesToCheck.forEach(f -> System.out.println("WARNING:" + f));
153153

154-
// TODO Fix all warning messages and then apply this validation
155-
// assertTrue(notesToCheck.isEmpty(), "Notes fom SUNAT:\n" + String.join("\n", notesToCheck));
154+
assertTrue(notesToCheck.isEmpty(), "Notes fom SUNAT:\n" + String.join("\n", notesToCheck));
156155
}
157156

158157
// Check ticket

‎src/test/java/io/github/project/openubl/xmlbuilderlib/integrationtest/ubl/SpecialCharactersTest.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,6 @@ void testVoidedDocument_Factura_MinData() throws Exception {
7474
// Then
7575
assertOutputHasNoConstraintViolations(validator, output);
7676
assertSnapshot(xml, "xml/invoice_specialCharacters.xml");
77-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
77+
assertSendSunat(xml);
7878
}
7979
}

‎src/test/java/io/github/project/openubl/xmlbuilderlib/integrationtest/ubl/creditnote/formapago/CreditNoteFormaPagoTest.java‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ public void testCreditNoteSinFormaPago_afectaFactura() throws Exception {
7878
// Then
7979
assertOutputHasNoConstraintViolations(validator, output);
8080
assertSnapshot(xml, "xml/creditnote/formapago/sinFormaPago_afectaFactura.xml");
81-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
81+
assertSendSunat(xml);
8282
}
8383

8484
@Test
@@ -122,7 +122,7 @@ public void testCreditNoteSinFormaPago_afectaBoleta() throws Exception {
122122
// Then
123123
assertOutputHasNoConstraintViolations(validator, output);
124124
assertSnapshot(xml, "xml/creditnote/formapago/sinFormaPago_afectaBoleta.xml");
125-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
125+
assertSendSunat(xml);
126126
}
127127

128128
@Test
@@ -189,7 +189,7 @@ public void testCreditNoteConFormaPago_afectaFactura() throws Exception {
189189
// Then
190190
assertOutputHasNoConstraintViolations(validator, output);
191191
assertSnapshot(xml, "xml/creditnote/formapago/conFormaPago_afectaFactura.xml");
192-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
192+
assertSendSunat(xml);
193193
}
194194

195195
@Test
@@ -256,6 +256,6 @@ public void testCreditNoteConFormaPago_afectaBoleta() throws Exception {
256256
// Then
257257
assertOutputHasNoConstraintViolations(validator, output);
258258
assertSnapshot(xml, "xml/creditnote/formapago/conFormaPago_afectaBoleta.xml");
259-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
259+
assertSendSunat(xml);
260260
}
261261
}

‎src/test/java/io/github/project/openubl/xmlbuilderlib/integrationtest/ubl/creditnote/mindata/CreditNoteMinDataTest.java‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public void testCreditNoteWithMinDataSent_customerWithRuc() throws Exception {
7676
// Then
7777
assertOutputHasNoConstraintViolations(validator, output);
7878
assertSnapshot(xml, "xml/creditnote/mindata/MinData_RUC.xml");
79-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
79+
assertSendSunat(xml);
8080
}
8181

8282
@Test
@@ -120,7 +120,7 @@ void testCreditNoteWithMinDataSent_customerWithDni() throws Exception {
120120
// Then
121121
assertOutputHasNoConstraintViolations(validator, output);
122122
assertSnapshot(xml, "xml/creditnote/mindata/MinData_DNI.xml");
123-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
123+
assertSendSunat(xml);
124124
}
125125

126126
@Test
@@ -164,7 +164,7 @@ void testCreditNoteWithMinDataSent_customerWithDocTribNoDomSinRuc() throws Excep
164164
// Then
165165
assertOutputHasNoConstraintViolations(validator, output);
166166
assertSnapshot(xml, "xml/creditnote/mindata/MinData_DocTribNoDomSinRuc.xml");
167-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
167+
assertSendSunat(xml);
168168
}
169169

170170
@Test
@@ -208,7 +208,7 @@ void testCreditNoteWithMinDataSent_customerWithExtranjeria() throws Exception {
208208
// Then
209209
assertOutputHasNoConstraintViolations(validator, output);
210210
assertSnapshot(xml, "xml/creditnote/mindata/MinData_Extranjeria.xml");
211-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
211+
assertSendSunat(xml);
212212
}
213213

214214
@Test
@@ -252,7 +252,7 @@ void testCreditNoteWithMinDataSent_customerWithPasaporte() throws Exception {
252252
// Then
253253
assertOutputHasNoConstraintViolations(validator, output);
254254
assertSnapshot(xml, "xml/creditnote/mindata/MinData_Pasaporte.xml");
255-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
255+
assertSendSunat(xml);
256256
}
257257

258258
@Test
@@ -296,7 +296,7 @@ void testCreditNoteWithMinDataSent_customerWithDecDiplomatica() throws Exception
296296
// Then
297297
assertOutputHasNoConstraintViolations(validator, output);
298298
assertSnapshot(xml, "xml/creditnote/mindata/MinData_DecDiplomatica.xml");
299-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
299+
assertSendSunat(xml);
300300
}
301301

302302
@Test
@@ -340,7 +340,7 @@ void testCreditNoteWithMinDataSent_usePrecioUnitario() throws Exception {
340340
// Then
341341
assertOutputHasNoConstraintViolations(validator, output);
342342
assertSnapshot(xml, "xml/creditnote/mindata/MinData_UsePrecioUnitarioOPrecioConIgv.xml");
343-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
343+
assertSendSunat(xml);
344344
}
345345

346346
@Test
@@ -384,7 +384,7 @@ void testCreditNoteWithMinDataSent_usePrecioConIgv() throws Exception {
384384
// Then
385385
assertOutputHasNoConstraintViolations(validator, output);
386386
assertSnapshot(xml, "xml/creditnote/mindata/MinData_UsePrecioUnitarioOPrecioConIgv.xml");
387-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
387+
assertSendSunat(xml);
388388
}
389389

390390
@Test
@@ -428,7 +428,7 @@ void testCreditNoteWithMinDataSent_usePrecioUnitarioAndCantidadThreeDecimals() t
428428
// Then
429429
assertOutputHasNoConstraintViolations(validator, output);
430430
assertSnapshot(xml, "xml/creditnote/mindata/MinData_UsePrecioUnitarioOPrecioConIgvAndCantidadThreeDecimals.xml");
431-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
431+
assertSendSunat(xml);
432432
}
433433

434434
@Test
@@ -472,6 +472,6 @@ void testCreditNoteWithMinDataSent_usePrecioConIgvAndCantidadThreeDecimals() thr
472472
// Then
473473
assertOutputHasNoConstraintViolations(validator, output);
474474
assertSnapshot(xml, "xml/creditnote/mindata/MinData_UsePrecioUnitarioOPrecioConIgvAndCantidadThreeDecimals.xml");
475-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
475+
assertSendSunat(xml);
476476
}
477477
}

‎src/test/java/io/github/project/openubl/xmlbuilderlib/integrationtest/ubl/creditnote/tiponota/CreditNoteTipoNotaTest.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ void testCreditNoteTipoNota_GravadoOnerosa_precioUnitario() throws Exception {
8080
// Then
8181
assertOutputHasNoConstraintViolations(validator, output);
8282
assertSnapshot(xml, "xml/creditnote/tiponota/descuentoPorItem.xml");
83-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
83+
assertSendSunat(xml);
8484
}
8585

8686
}

‎src/test/java/io/github/project/openubl/xmlbuilderlib/integrationtest/ubl/debitnote/mindata/DebitNoteMinDataTest.java‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ void testDebitNoteWithMinDataSent_customerWithRuc() throws Exception {
7676
// Then
7777
assertOutputHasNoConstraintViolations(validator, output);
7878
assertSnapshot(xml, "xml/debitnote/mindata/MinData_RUC.xml");
79-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
79+
assertSendSunat(xml);
8080
}
8181

8282
@Test
@@ -122,7 +122,7 @@ void testDebitNoteWithMinDataSent_customerWithDni() throws Exception {
122122
// Then
123123
assertOutputHasNoConstraintViolations(validator, output);
124124
assertSnapshot(xml, "xml/debitnote/mindata/MinData_DNI.xml");
125-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
125+
assertSendSunat(xml);
126126
}
127127

128128
@Test
@@ -166,7 +166,7 @@ void testDebitNoteWithMinDataSent_customerWithDocTribNoDomSinRuc() throws Except
166166
// Then
167167
assertOutputHasNoConstraintViolations(validator, output);
168168
assertSnapshot(xml, "xml/debitnote/mindata/MinData_DocTribNoDomSinRuc.xml");
169-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
169+
assertSendSunat(xml);
170170
}
171171

172172
@Test
@@ -212,7 +212,7 @@ void testDebitNoteWithMinDataSent_customerWithExtranjeria() throws Exception {
212212
// Then
213213
assertOutputHasNoConstraintViolations(validator, output);
214214
assertSnapshot(xml, "xml/debitnote/mindata/MinData_Extranjeria.xml");
215-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
215+
assertSendSunat(xml);
216216
}
217217

218218
@Test
@@ -258,7 +258,7 @@ void testDebitNoteWithMinDataSent_customerWithPasaporte() throws Exception {
258258
// Then
259259
assertOutputHasNoConstraintViolations(validator, output);
260260
assertSnapshot(xml, "xml/debitnote/mindata/MinData_Pasaporte.xml");
261-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
261+
assertSendSunat(xml);
262262
}
263263

264264
@Test
@@ -302,7 +302,7 @@ void testDebitNoteWithMinDataSent_customerWithDecDiplomatica() throws Exception
302302
// Then
303303
assertOutputHasNoConstraintViolations(validator, output);
304304
assertSnapshot(xml, "xml/debitnote/mindata/MinData_DecDiplomatica.xml");
305-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
305+
assertSendSunat(xml);
306306
}
307307

308308
@Test
@@ -346,7 +346,7 @@ void testDebitNoteWithMinDataSent_usePrecioUnitario() throws Exception {
346346
// Then
347347
assertOutputHasNoConstraintViolations(validator, output);
348348
assertSnapshot(xml, "xml/debitnote/mindata/MinData_UsePrecioUnitarioOPrecioConIgv.xml");
349-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
349+
assertSendSunat(xml);
350350
}
351351

352352
@Test
@@ -390,7 +390,7 @@ void testDebitNoteWithMinDataSent_usePrecioConIgv() throws Exception {
390390
// Then
391391
assertOutputHasNoConstraintViolations(validator, output);
392392
assertSnapshot(xml, "xml/debitnote/mindata/MinData_UsePrecioUnitarioOPrecioConIgv.xml");
393-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
393+
assertSendSunat(xml);
394394
}
395395

396396
@Test
@@ -434,7 +434,7 @@ void testDebitNoteWithMinDataSent_usePrecioUnitarioAndCantidadThreeDecimals() th
434434
// Then
435435
assertOutputHasNoConstraintViolations(validator, output);
436436
assertSnapshot(xml, "xml/debitnote/mindata/MinData_UsePrecioUnitarioOPrecioConIgvAndCantidadThreeDecimals.xml");
437-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
437+
assertSendSunat(xml);
438438
}
439439

440440
@Test
@@ -480,7 +480,7 @@ void testDebitNoteWithMinDataSent_usePrecioConIgvAndCantidadThreeDecimals() thro
480480
// Then
481481
assertOutputHasNoConstraintViolations(validator, output);
482482
assertSnapshot(xml, "xml/debitnote/mindata/MinData_UsePrecioUnitarioOPrecioConIgvAndCantidadThreeDecimals.xml");
483-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
483+
assertSendSunat(xml);
484484
}
485485

486486
}

‎src/test/java/io/github/project/openubl/xmlbuilderlib/integrationtest/ubl/debitnote/tiponota/DebitNoteTipoNotaTest.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ void testDebitNoteTipoNota_GravadoOnerosa_precioUnitario() throws Exception {
7979
// Then
8080
assertOutputHasNoConstraintViolations(validator, output);
8181
assertSnapshot(xml, "xml/debitnote/tiponota/descuentoPorItem.xml");
82-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
82+
assertSendSunat(xml);
8383
}
8484

8585
}

‎src/test/java/io/github/project/openubl/xmlbuilderlib/integrationtest/ubl/invoice/InvoiceTest.java‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ void testInvoiceWithCustomUnidadMedida() throws Exception {
7676
// Then
7777
assertOutputHasNoConstraintViolations(validator, output);
7878
assertSnapshot(xml, "xml/invoice/customUnidadMedida.xml");
79-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
79+
assertSendSunat(xml);
8080
}
8181

8282
@Test
@@ -123,7 +123,7 @@ void testInvoiceWithCustomFechaEmision() throws Exception {
123123
// Then
124124
assertOutputHasNoConstraintViolations(validator, output);
125125
assertSnapshot(xml, "xml/invoice/customFechaEmision.xml");
126-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
126+
assertSendSunat(xml);
127127
}
128128

129129
@Test
@@ -179,7 +179,7 @@ void testInvoiceWithCustomClienteDireccionAndContacto() throws Exception {
179179
// Then
180180
assertOutputHasNoConstraintViolations(validator, output);
181181
assertSnapshot(xml, "xml/invoice/customClienteDireccionAndContacto.xml");
182-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
182+
assertSendSunat(xml);
183183
}
184184

185185
@Test
@@ -284,7 +284,7 @@ void testInvoiceWithCustomFirmante() throws Exception {
284284
// Then
285285
assertOutputHasNoConstraintViolations(validator, output);
286286
assertSnapshot(xml, "xml/invoice/customFirmante.xml");
287-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
287+
assertSendSunat(xml);
288288
}
289289

290290
@Test
@@ -333,7 +333,7 @@ void testInvoiceWithICB_precioUnitario() throws Exception {
333333
// Then
334334
assertOutputHasNoConstraintViolations(validator, output);
335335
assertSnapshot(xml, "xml/invoice/icb.xml");
336-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
336+
assertSendSunat(xml);
337337
}
338338

339339
@Test
@@ -382,7 +382,7 @@ void testInvoiceWithICB_precioConIgv() throws Exception {
382382
// Then
383383
assertOutputHasNoConstraintViolations(validator, output);
384384
assertSnapshot(xml, "xml/invoice/icb.xml");
385-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
385+
assertSendSunat(xml);
386386
}
387387

388388
@Test
@@ -435,6 +435,6 @@ void testInvoiceWithCustomProveedor_direccionNotNullAndCodigoLocalNull() throws
435435
// Then
436436
assertOutputHasNoConstraintViolations(validator, output);
437437
assertSnapshot(xml, "xml/invoice/customCodigoLocal.xml");
438-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
438+
assertSendSunat(xml);
439439
}
440440
}

‎src/test/java/io/github/project/openubl/xmlbuilderlib/integrationtest/ubl/invoice/issues/Issue30.java‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ void testInvoice_withPrecioUnitario() throws Exception {
8484
// Then
8585
assertOutputHasNoConstraintViolations(validator, output);
8686
assertSnapshot(xml, "xml/invoice/issues/issue-30-with-precioUnitario.xml");
87-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
87+
assertSendSunat(xml);
8888
}
8989

9090
@Test
@@ -130,7 +130,7 @@ void testInvoice_withPrecioConIgv() throws Exception {
130130
// Then
131131
assertOutputHasNoConstraintViolations(validator, output);
132132
assertSnapshot(xml, "xml/invoice/issues/issue-30-with-precioConIgv.xml");
133-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
133+
assertSendSunat(xml);
134134
}
135135

136136
@Test
@@ -177,7 +177,7 @@ void testInvoice_withPrecioUnitario_andICB() throws Exception {
177177
// Then
178178
assertOutputHasNoConstraintViolations(validator, output);
179179
assertSnapshot(xml, "xml/invoice/issues/issue-30-with-precioUnitario_andICB.xml");
180-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
180+
assertSendSunat(xml);
181181
}
182182

183183
@Test
@@ -224,6 +224,6 @@ void testInvoice_withPrecioConIgv_andICB() throws Exception {
224224
// Then
225225
assertOutputHasNoConstraintViolations(validator, output);
226226
assertSnapshot(xml, "xml/invoice/issues/issue-30-with-precioConIgv_andICB.xml");
227-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
227+
assertSendSunat(xml);
228228
}
229229
}

‎src/test/java/io/github/project/openubl/xmlbuilderlib/integrationtest/ubl/invoice/mindata/InvoiceMinDataTest.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,7 @@ void testInvoiceWithMinDataSent_customerWithDecDiplomatica() throws Exception {
286286
// Then
287287
assertOutputHasNoConstraintViolations(validator, output);
288288
assertSnapshot(xml, "xml/invoice/mindata/MinData_DecDiplomatica.xml");
289-
assertSendSunat(xml, PROVIDER_WITHOUT_ADDRESS_NOTE);
289+
assertSendSunat(xml);
290290
}
291291

292292
@Test

0 commit comments

Comments
 (0)