ci: Merge MLIR Backend (#758)

Author: hameerabbasi

.coveragerc

@@ -4,8 +4,7 @@ source=
 
 omit=
     sparse/_version.py
-    sparse/tests/*
-    sparse/numba_backend/tests/*
+    **/tests/*
 
 [report]
 exclude_lines =

.github/workflows/ci.yml

@@ -10,7 +10,7 @@ jobs:
   test:
     strategy:
       matrix:
-        os: [ubuntu-latest]
+        os: ['ubuntu-latest']
         python: ['3.10', '3.11', '3.12']
         pip_opts: ['']
         numba_boundscheck: [0]
@@ -34,51 +34,30 @@ jobs:
     steps:
       - name: Checkout Repo
         uses: actions/checkout@v4
-      - name: Set up Python
-        uses: actions/setup-python@v5
+      - uses: mamba-org/setup-micromamba@v1
         with:
-          python-version: ${{ matrix.python }}
-          cache: 'pip'
+          environment-file: ci/environment.yml
+          init-shell: >-
+            bash
+          cache-environment: true
+          cache-downloads: true
+          post-cleanup: 'all'
+          create-args: >-
+            python=${{ matrix.python }}
+            ${{ matrix.pip_opts }}
       - name: Install package
         run: |
           pip install -e '.[tests]'
-          if [ "${{ matrix.pip_opts }}" != "" ]; then
-            pip install "${{ matrix.pip_opts }}" numba
-          fi
       - name: Run tests
         run: |
-          SPARSE_BACKEND=Numba pytest --pyargs sparse --cov-report=xml:coverage_Numba.xml -n 4 -vvv
-          SPARSE_BACKEND=Finch pytest --pyargs sparse/tests --cov-report=xml:coverage_Finch.xml -n 4 -vvv
+          SPARSE_BACKEND=Numba pytest --pyargs sparse --cov-report=xml:coverage_Numba.xml -n auto -vvv
+          SPARSE_BACKEND=Finch pytest --pyargs sparse/tests --cov-report=xml:coverage_Finch.xml -n auto -vvv
+          SPARSE_BACKEND=MLIR pytest --pyargs sparse/mlir_backend --cov-report=xml:coverage_MLIR.xml -n auto -vvv
       - uses: codecov/codecov-action@v4
         if: always()
         with:
           files: ./**/coverage*.xml
 
-  test_mlir:
-    runs-on: ubuntu-latest
-    steps:
-    - name: Checkout Repo
-      uses: actions/checkout@v4
-    - name: Setup Conda
-      uses: conda-incubator/setup-miniconda@v3
-      with:
-        python-version: '3.10'
-        channels: conda-forge
-        activate-environment: sparse-dev
-        miniforge-variant: Mambaforge
-        miniforge-version: latest
-        use-mamba: true
-    - name: Update Conda Environment
-      run: |
-        mamba env update -n sparse-dev -f ci/environment.yml
-        mamba run pip install '.[tests]'
-        mamba install conda-forge::mlir-python-bindings
-    - name: Build and run tests
-      shell: bash -l {0}
-      run: |
-        conda activate sparse-dev
-        SPARSE_BACKEND=MLIR pytest sparse/mlir_backend -v
-
   examples:
     runs-on: ubuntu-latest
     steps:
@@ -147,7 +126,7 @@ jobs:
         SPARSE_BACKEND: ${{ matrix.backend }}
       run: |
         cd ${GITHUB_WORKSPACE}/array-api-tests
-        pytest array_api_tests -v -c pytest.ini -n 4 --max-examples=2 --derandomize --disable-deadline -o xfail_strict=True --xfails-file ${GITHUB_WORKSPACE}/ci/${{ matrix.backend }}-array-api-xfails.txt --skips-file ${GITHUB_WORKSPACE}/ci/${{ matrix.backend }}-array-api-skips.txt
+        pytest array_api_tests -v -c pytest.ini -n auto --max-examples=2 --derandomize --disable-deadline -o xfail_strict=True --xfails-file ${GITHUB_WORKSPACE}/ci/${{ matrix.backend }}-array-api-xfails.txt --skips-file ${GITHUB_WORKSPACE}/ci/${{ matrix.backend }}-array-api-skips.txt
 
 on:
   # Trigger the workflow on push or pull request,

ci/environment.yml

@@ -1,6 +1,17 @@
 name: sparse-dev
 channels:
   - conda-forge
+  - nodefaults
 dependencies:
   - python
-  - pip
+  - numpy
+  - numba
+  - scipy
+  - dask
+  - pytest
+  - pytest-cov
+  - pytest-xdist
+  - mlir-python-bindings
+  - pip:
+    - finch-tensor >=0.1.31
+    - pytest-codspeed

sparse/mlir_backend/_core.py

@@ -8,7 +8,7 @@
 SCRIPT_PATH = pathlib.Path(__file__).parent
 
 MLIR_C_RUNNER_UTILS = ctypes.util.find_library("mlir_c_runner_utils")
-libc = ctypes.CDLL(ctypes.util.find_library("c"))
+libc = ctypes.CDLL(ctypes.util.find_library("c")) if os.name != "nt" else ctypes.cdll.msvcrt
 libc.free.argtypes = [ctypes.c_void_p]
 libc.free.restype = None
 

sparse/mlir_backend/tests/test_simple.py

@@ -9,6 +9,10 @@
     pytest.skip("skipping MLIR tests", allow_module_level=True)
 
 
+def assert_csr_equal(expected: sps.csr_array, actual: sps.csr_array) -> None:
+    np.testing.assert_array_equal(expected.todense(), actual.todense())
+
+
 def test_constructors(rng):
     SHAPE = (10, 5)
     DENSITY = 0.5
@@ -20,9 +24,7 @@ def test_constructors(rng):
     c_tensor = sparse.asarray(c)
 
     a_retured = a_tensor.to_scipy_sparse()
-    np.testing.assert_array_equal(a_retured.indices, a.indices)
-    np.testing.assert_array_equal(a_retured.indptr, a.indptr)
-    np.testing.assert_array_equal(a_retured.data, a.data)
+    assert_csr_equal(a, a_retured)
 
     c_returned = c_tensor.to_scipy_sparse()
     np.testing.assert_array_equal(c_returned, c)
@@ -42,15 +44,11 @@ def test_add(rng):
 
     actual = sparse.add(a_tensor, b_tensor).to_scipy_sparse()
     expected = a + b
-    np.testing.assert_array_equal(actual.indices, expected.indices)
-    np.testing.assert_array_equal(actual.indptr, expected.indptr)
-    np.testing.assert_array_equal(actual.data, expected.data)
+    assert_csr_equal(expected, actual)
 
     actual = sparse.add(a_tensor, c_tensor).to_scipy_sparse()
     expected = sps.csr_matrix(a + c)
-    np.testing.assert_array_equal(actual.indices, expected.indices)
-    np.testing.assert_array_equal(actual.indptr, expected.indptr)
-    np.testing.assert_array_equal(actual.data, expected.data)
+    assert_csr_equal(expected, actual)
 
     actual = sparse.add(c_tensor, a_tensor).to_scipy_sparse()
     expected = a + c