Split swagger conf in other class

Author: avara1986

pyms/constants.py

@@ -1,3 +1,6 @@
 CONFIGMAP_FILE_ENVIRONMENT = "CONFIGMAP_FILE"
 
-LOGGER_NAME = "pyms"
+LOGGER_NAME = "pyms"
+
+SWAGGER_PATH = "swagger"
+SWAGGER_FILE = "swagger.yaml"

pyms/flask/app/__init__.py

@@ -6,6 +6,7 @@
 from flask_opentracing import FlaskTracer
 
 from pyms.config.conf import get_conf
+from pyms.flask.app.swagger import Swagger
 from pyms.flask.healthcheck import healthcheck_blueprint
 from pyms.logger import CustomJsonFormatter
 from pyms.tracer.main import init_jaeger_tracer
@@ -18,6 +19,8 @@ class Microservice:
     def __init__(self, service: Text, path=__file__):
         self.service = service
         self.path = os.path.dirname(path)
+        self.swagger = Swagger()
+        self.config = get_conf(service=self.service)
 
     def init_libs(self):
         return self.application
@@ -29,16 +32,16 @@ def create_app(self):
         return the app and the database objects.
         :return:
         """
-        config = get_conf(service=self.service)
-        app = connexion.App(__name__, specification_dir=os.path.join(self.path, 'swagger'))
-        app.add_api('swagger.yaml',
-                    arguments={'title': config.APP_NAME},
-                    base_path=config.APPLICATION_ROOT
+
+        app = connexion.App(__name__, specification_dir=os.path.join(self.path, self.swagger.path))
+        app.add_api(self.swagger.file,
+                    arguments={'title': self.config.APP_NAME},
+                    base_path=self.config.APPLICATION_ROOT
                     )
 
         self.application = app.app
         self.application._connexion_app = app
-        self.application.config.from_object(config)
+        self.application.config.from_object(self.config)
         self.application.tracer = None
 
         # Initialize Blueprints
@@ -74,5 +77,4 @@ def add_error_handler(self, code_or_exception, handler):
         :param code_or_exception: HTTP error code or exception
         :param handler: callback for error handler
         """
-
         self.application._connexion_app.add_error_handler(code_or_exception, handler)

pyms/flask/app/swagger.py

@@ -0,0 +1,21 @@
+from pyms.exceptions import AttrDoesNotExistException
+
+from pyms.config.conf import get_conf
+from pyms.constants import SWAGGER_PATH, SWAGGER_FILE
+
+
+class Swagger:
+    service = "swagger"
+
+    def __init__(self):
+        self.config = get_conf(service=self.service, empty_init=True)
+
+    @property
+    def path(self):
+        path = self.config.path
+        return path if path else SWAGGER_PATH
+
+    @property
+    def file(self):
+        swagger_file = self.config.file
+        return swagger_file if swagger_file else SWAGGER_FILE