Skip to content

Commit e70f4be

Browse files
authored
Add service name label by default (#84)
It adds a label to all jaeger's generated metrics that can be used to identify every microservice. See jaegertracing/jaeger-client-python#269. I messed up the previous PR, it's the same as this. #72
1 parent 1c90261 commit e70f4be

File tree

3 files changed

+66
-47
lines changed

3 files changed

+66
-47
lines changed

Pipfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ pyyaml = ">=5.1.2"
1010
anyconfig = ">=0.9.8"
1111
swagger-ui-bundle = ">=0.0.2"
1212
connexion = {extras = ["swagger-ui"],version = "==2.4.0"}
13-
jaeger-client = "==4.2.0"
13+
jaeger-client = "==4.3.0"
1414
flask-opentracing = "*"
1515
opentracing = ">=2.1"
1616
opentracing-instrumentation = "==3.2.1"

Pipfile.lock

Lines changed: 63 additions & 45 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyms/flask/services/tracer.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,8 @@ def init_jaeger_tracer(self):
7171
metrics_config = get_conf(service=get_service_name(service="metrics"), empty_init=True)
7272
metrics = ""
7373
if metrics_config:
74-
metrics = PrometheusMetricsFactory()
74+
service_name = self.component_name.lower().replace("-", "_").replace(" ", "_")
75+
metrics = PrometheusMetricsFactory(service_name_label=service_name)
7576
config = Config(
7677
config={
7778
**{

0 commit comments

Comments
 (0)