code refactoring

Author: mihaj

src/QAToolKit.Engine.Bombardier/BombardierTestsGenerator.cs

@@ -1,5 +1,4 @@
-using QAToolKit.Core.Helpers;
-using QAToolKit.Core.Interfaces;
+using QAToolKit.Core.Interfaces;
 using QAToolKit.Core.Models;
 using QAToolKit.Engine.Bombardier.Helpers;
 using System;
@@ -23,7 +22,7 @@ public BombardierTestsGenerator(Action<BombardierOptions> options)
         }
 
         /// <summary>
-        /// Generate a Bombardier script
+        /// Generate a Bombardier script from requests
         /// </summary>
         /// <returns></returns>
         public async Task<IEnumerable<BombardierTest>> Generate(IList<HttpTestRequest> restRequests)

src/QAToolKit.Engine.Bombardier/BombardierTestsRunner.cs

@@ -19,6 +19,10 @@ public BombardierTestsRunner(IList<BombardierTest> bombardierTests)
             _bombardierTests = bombardierTests;
         }
 
+        /// <summary>
+        /// Run Bombardier tests
+        /// </summary>
+        /// <returns></returns>
         public async Task<IList<BombardierResult>> Run()
         {
             var bombardierResult = new List<BombardierResult>();

src/QAToolKit.Engine.Bombardier/Helpers/GeneratorHelper.cs

@@ -136,7 +136,7 @@ internal static string GenerateAuthHeader(HttpTestRequest request, BombardierOpt
             return authHeader;
         }
 
-        internal static string GetOauth2AuthenticationHeader(Dictionary<AuthenticationType, string> accessTokens, AuthenticationType authenticationType)
+        private static string GetOauth2AuthenticationHeader(Dictionary<AuthenticationType, string> accessTokens, AuthenticationType authenticationType)
         {
             string authHeader;
             if (accessTokens.ContainsKey(authenticationType))
@@ -146,13 +146,13 @@ internal static string GetOauth2AuthenticationHeader(Dictionary<AuthenticationTy
             }
             else
             {
-                throw new Exception("One of the access token is missing.");
+                throw new Exception($"One of the access token is missing (AuthenticationType {authenticationType.Value()} required).");
             }
 
             return authHeader;
         }
 
-        internal static string GetBasicAuthenticationHeader(BombardierOptions bombardierOptions)
+        private static string GetBasicAuthenticationHeader(BombardierOptions bombardierOptions)
         {
             string authHeader;
 
@@ -164,13 +164,13 @@ internal static string GetBasicAuthenticationHeader(BombardierOptions bombardier
             }
             else
             {
-                authHeader = String.Empty;
+                throw new Exception($"User name and password for basic authentication are missing and are required).");
             }
 
             return authHeader;
         }
 
-        internal static string GetApiKeyAuthenticationHeader(BombardierOptions bombardierOptions)
+        private static string GetApiKeyAuthenticationHeader(BombardierOptions bombardierOptions)
         {
             string authHeader;
 
@@ -180,7 +180,7 @@ internal static string GetApiKeyAuthenticationHeader(BombardierOptions bombardie
             }
             else
             {
-                authHeader = String.Empty;
+                throw new Exception($"Api Key is missing and is required.");
             }
 
             return authHeader;