more unit tests and refactorings

Author: mihaj

src/QAToolKit.Source.Swagger.Test/SwaggerFileSourceIntegrationTest.cs

@@ -3,14 +3,15 @@
 using System;
 using System.Collections.Generic;
 using System.IO;
+using System.Linq;
 using Xunit;
 
 namespace QAToolKit.Source.Swagger.Test
 {
     public class SwaggerFileSourceIntegrationTest
     {
         [Fact]
-        public async void SwaggerFileSourceWithoutOptionsTest_Successfull()
+        public async void SwaggerFileSourceWithOptionsTest_Successfull()
         {
             var fileSource = new SwaggerFileSource(options =>
             {
@@ -22,6 +23,17 @@ public async void SwaggerFileSourceWithoutOptionsTest_Successfull()
             });
 
             Assert.NotNull(requests);
+            Assert.Equal(19, requests.Count());
+        }
+
+        [Fact]
+        public async void SwaggerFileSourceWithoutOptionsTest_Fails()
+        {
+            var fileSource = new SwaggerFileSource();
+
+            await Assert.ThrowsAsync<Exception>(async () => await fileSource.Load(new List<FileInfo>() {
+                new FileInfo("Assets/swagger-test.json")
+            }));
         }
     }
 }

src/QAToolKit.Source.Swagger.Test/SwaggerUrlSourceIntegrationTests.cs

@@ -46,6 +46,16 @@ public async Task SwaggerUrlSourceWithOptionsV3Test_Successfull()
             Assert.NotNull(requests);
         }
 
+        [Fact]
+        public async Task SwaggerUrlSourceWithoutUrlV3Test_Fails()
+        {
+            var urlSource = new SwaggerUrlSource();
+            await Assert.ThrowsAsync<UriFormatException>(async () => await urlSource.Load(
+                new Uri[]
+                {
+                      new Uri("")
+                }));
+        }
 
         /* [Fact]
          public async Task SwaggerUrlSourceWithoutOptionsV2Test_Successfull()

src/QAToolKit.Source.Swagger/SwaggerFileSource.cs

@@ -35,6 +35,8 @@ public async Task<IList<HttpTestRequest>> Load(IList<FileInfo> source)
         {
             if (source == null) throw new ArgumentNullException(nameof(source));
 
+            if (_swaggerOptions.BaseUrl == null) throw new Exception("Swagger from file source needs BaseUrl defined. If absolute URL is defined in swagger file, that one will be used.");
+
             var restRequests = new List<HttpTestRequest>();
             var processor = new SwaggerProcessor();
 
@@ -53,10 +55,5 @@ public async Task<IList<HttpTestRequest>> Load(IList<FileInfo> source)
 
             return restRequests;
         }
-
-        internal Task Load(FileInfo fileInfo)
-        {
-            throw new NotImplementedException();
-        }
     }
 }