fix: No longer allowing 'sender.flush(buffer=None, clear=False)' which was a bug.

Author: amunra

src/questdb/ingress.pyx

@@ -91,7 +91,7 @@ class IngressErrorCode(Enum):
     AuthError = line_sender_error_auth_error
     TlsError = line_sender_error_tls_error
 
-    def __str__(self):
+    def __str__(self) -> str:
         return self.name
 
 
@@ -929,6 +929,9 @@ cdef class Sender:
         self._buffer.row(*args, **kwargs)
 
     cpdef flush(self, Buffer buffer=None, bint clear=True):
+        if buffer is None and not clear:
+            raise ValueError('The internal buffer must always be cleared.')
+
         cdef line_sender_error* err = NULL
         cdef line_sender_buffer* c_buf = NULL
         if self._impl == NULL:

test/test.py

@@ -1,6 +1,7 @@
 #!/usr/bin/env python3
 
 import sys
+from turtle import clear
 sys.dont_write_bytecode = True
 import os
 import unittest
@@ -176,6 +177,16 @@ def test_flush_3(self):
                         sender.row('tbl1', symbols={'a': 'b'})
                         sender.flush()
 
+    def test_flush_4(self):
+        # Clearing of the internal buffer is not allowed.
+        with Server() as server:
+            with self.assertRaises(ValueError):
+                with qi.Sender('localhost', server.port) as sender:
+                    server.accept()
+                    sender.row('tbl1', symbols={'a': 'b'})
+                    sender.flush(buffer=None, clear=False)
+
+
     def test_independent_buffer(self):
         buf = qi.Buffer()
         buf.row('tbl1', symbols={'sym1': 'val1'})