Skip to content

Commit 092e61e

Browse files
gmake run-broker, gmake start-cluster: use a very small default plugin list
Currently both commands start a node with all plugins. That's never the user's intent and it can result in confusing plugin conflicts that would have never happened in any real world plugin configuration.
1 parent 506176e commit 092e61e

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

Makefile

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -66,16 +66,17 @@ ifdef COMMUNITY_PLUGINS
6666
DEPS += $(RABBITMQ_COMMUNITY)
6767
endif
6868

69+
# Plugins to enable for `gmake run-broker`, `gmake start-cluster`, etc.
70+
# To override:
71+
# gmake run-broker ENABLED_PLUGINS="rabbitmq_management rabbitmq_stream"
72+
# gmake start-cluster NODES=3 ENABLED_PLUGINS="rabbitmq_management rabbitmq_stream rabbitmq_stream_management"
73+
ENABLED_PLUGINS ?= rabbitmq_management
74+
RABBITMQ_ENABLED_PLUGINS ?= $(call comma_list,$(ENABLED_PLUGINS))
75+
export RABBITMQ_ENABLED_PLUGINS
76+
6977
include erlang.mk
7078
include mk/github-actions.mk
7179

72-
# If PLUGINS was set when we use run-broker we want to
73-
# fill in the enabled plugins list. PLUGINS is a more
74-
# natural space-separated list.
75-
ifdef PLUGINS
76-
RABBITMQ_ENABLED_PLUGINS ?= $(call comma_list,$(PLUGINS))
77-
endif
78-
7980
# --------------------------------------------------------------------
8081
# Distribution - common variables and generic functions.
8182
# --------------------------------------------------------------------

0 commit comments

Comments
 (0)